commit 1ab3b1bcfa5f8ce75b32b096f44a91327367ab1f
author Mike Burrows <m3b@google.com> Mon Jun 06 10:53:27 2016 -0700
committer Mike Burrows <m3b@google.com> Mon Jun 06 10:53:27 2016 -0700
tree 2cfaba1e204b68d12edf77f5df11039b45370006
parent 693f4a8589921c7c42979bf7eec639722397dabd

v.io: fix places where context.T cancellation functions are not called.

context.T (like its standard Go namesake) requires that the cancellation
function returned by WithCancel() be called, of the context object will be
leaked.  The same is true of WithTimeout() to a lesser degree---one might
ignore the issue if the timeout is short.

This change fixed a number of places where we curently fail to call the
cancellation function.

Some are only on error paths that will be taken only rarely.

Some are on timeout cases, which we could ignore, but for the moment, I'm
trying to be thorough, primarily because existing code acts as a template for
future code, and it seems better to encourage good habits.

In a couple of cases, the existing code is correct, but I added a comment to
explain that a call is not needed.

MultiPart: 1/2
Change-Id: Ic5b074549e33472d1cdd8929a864fd020a9b2890