tree 5571a8f0065507e804d1981de73cb8158002484a
parent 775027efccbe56c2faf9d2abe0fe9ca17c6ed0d1
author Todd Wang <toddw@google.com> 1461714841 -0700
committer Todd Wang <toddw@google.com> 1461714991 -0700

Remove time.Deadline 0 value semantics.

[See below about a bugfix attached to this CL]

As a recap, time.Deadline is a native type representing deadlines
using an absolute time, while time.WireDeadline is a wire type
representing deadlines using a relative duration from now.

In both old and new code, the native time.Deadline indicates "no
deadline" using time.Time.IsZero().

The old code set WireDeadline.NoDeadline to indicate the "no
deadline" case.  This is bad, since it means the zero-value
semantics are different between the native and wire types, which
is annoying for VDL/VOM.

The new code removes the WireDeadline.NoDeadline field, and
instead uses WireDeadline.FromNow=0 as a sentry to indicate "no
deadline".  This leaves open a tiny (but non-zero) possibility
that new binaries will interpret old binaries incorrectly.  But
that seems fine for now; even if it happens, it shouldn't have a
big impact.

[BUGFIX]
Annoyingly this exposed a bug in the old generated decoders.  We
need to return the special-case vdl.ErrFieldNoExist when
encountering non-existent fields, in order for backwards
compatibility to work for unknown struct fields.  But we
weren't.  This CL also fixes that bug.

MultiPart: 2/4
Change-Id: I8d63c9ce48dad42b934b92be146e0c56fdab1266