tree fb045cddea9721880c72de6430dbb301566ea7e4
parent cd5d83a8b5fb996e397962471f231d7bd7ae6d52
author Adam Sadovsky <asadovsky@gmail.com> 1450146579 -0800
committer Adam Sadovsky <asadovsky@gmail.com> 1450146579 -0800

lib: update various tests to use v23test

In particular, this CL updates a handful of "v23_test.go"
tests, as well as nearly all of the "v23_internal_test.go"
tests (many of which didn't need v23tests / go generate at
all).

I'd initially suggested doing one massive CL to update all
tests, but my feeling now is that incremental CLs will be
easier to review and will make it easier to tweak
gosh/v23test as needed along the way. Let me know if you
prefer the "one massive CL" approach, though.

Includes a few updates to gosh and v23test:
- Adjust semantics of Shell.Cleanup to allow for multiple
calls, where calls after the first have no effect. This
facilitates Shell wrapping, a la v23test.Shell.
- Update v23test.NewShell to fix edge cases around cleanup,
leveraging the new gosh.Shell.Cleanup semantics.
- Update {,Combined}Output to return strings, since strings
are more convenient and these methods are anyways not
meant for performance/size-sensitive applications.

MultiPart: 1/2

Change-Id: Ib9dfa3d0c7931963e652f1754ff55cc2f2605b52