tree 46b0bd040397f5188221061510ddf90c0a1f6e18
parent e446fbd5c32c16e0a7bc8bd600b4582e20bb7a4f
author Adam Sadovsky <asadovsky@gmail.com> 1452054512 -0800
committer Adam Sadovsky <asadovsky@gmail.com> 1452054514 -0800

gosh: handle same WriteCloser passed to Add{Stdout,Stderr}Writer

Also, a few minor cleanups:
- Update all tests to set sh.Opts.Fatalf to nil as the
  canonical way to disable fatal'ing
- Tweak TestAddWritersUnwrappedStdoutStderr to avoid loops,
  since the loop-free impl is still short and will give more
  useful output on failure
- Expand comment for Cmd.Args to make it clear that it
  doesn't include the path

Note, Cmd.Args not including the path is different from
exec.Cmd, but it seems more sensible given that otherwise
there's an awkward overlap between Cmd.Path and Cmd.Args.
(Also, exec.Cmd special-cases for Cmd.Args==nil, setting it
to []string{Cmd.Path} in that case, which seems a bit
inelegant.)

Change-Id: Icadc8bb892129b67fc060857e4efa0545ea5ce01