Addressed comments
Change-Id: I4688cba5e6ffc2ad1380b04343d7ef82d211af3b
diff --git a/services/wspr/internal/app/app.go b/services/wspr/internal/app/app.go
index 140203f..9357713 100644
--- a/services/wspr/internal/app/app.go
+++ b/services/wspr/internal/app/app.go
@@ -36,7 +36,8 @@
const (
// pkgPath is the prefix os errors in this package.
- pkgPath = "v.io/x/ref/services/wspr/internal/app"
+ pkgPath = "v.io/x/ref/services/wspr/internal/app"
+ typeFlow = 0
)
// Errors
@@ -373,7 +374,7 @@
c.servers = make(map[uint32]*server.Server)
c.typeReader = lib.NewTypeReader()
c.typeDecoder = vom.NewTypeDecoder(c.typeReader)
- c.typeEncoder = vom.NewTypeEncoder(lib.NewTypeWriter(c.writerCreator(0)))
+ c.typeEncoder = vom.NewTypeEncoder(lib.NewTypeWriter(c.writerCreator(typeFlow)))
c.lastGeneratedId += 2
}
diff --git a/services/wspr/internal/lib/binary_util.go b/services/wspr/internal/lib/binary_util.go
index 9ddc65c..f35aa34 100644
--- a/services/wspr/internal/lib/binary_util.go
+++ b/services/wspr/internal/lib/binary_util.go
@@ -18,6 +18,9 @@
errUintOverflow = verror.Register(pkgPath+".errUintOverflow", verror.NoRetry, "{1:}{2:} wspr: scalar larger than 8 bytes{:_}")
)
+// The logic of the two functions here are copied from the vom implementations and
+// should be kept in sync.
+
// Unsigned integers are the basis for all other primitive values. This is a
// two-state encoding. If the number is less than 128 (0 through 0x7f), its
// value is written directly. Otherwise the value is written in big-endian byte
