ipc: VCSecurityLevel->Security and no longer a stream opt.
SecurityLevel is not handled only in server.go and client.go.
Everywhere else in the ipc stack, nil principal means SecurityNone.
This also fixes https://github.com/veyron/release-issues/issues/1423
in the process.
MultiPart: 1/2
Change-Id: I55646e574e43b633c69300b1fecb623c95340bbc
diff --git a/profiles/internal/rpc/full_test.go b/profiles/internal/rpc/full_test.go
index aa1d52d..6789fda 100644
--- a/profiles/internal/rpc/full_test.go
+++ b/profiles/internal/rpc/full_test.go
@@ -1608,7 +1608,7 @@
sm := imanager.InternalNew(naming.FixedRoutingID(0x66666666))
defer sm.Shutdown()
ns := tnaming.NewSimpleNamespace()
- server, err := testInternalNewServer(ctx, sm, ns, nil, options.VCSecurityNone)
+ server, err := testInternalNewServer(ctx, sm, ns, nil, options.SecurityNone)
if err != nil {
t.Fatalf("InternalNewServer failed: %v", err)
}
@@ -1623,9 +1623,9 @@
if err != nil {
t.Fatalf("InternalNewClient failed: %v", err)
}
- // When using VCSecurityNone, all authorization checks should be skipped, so
+ // When using SecurityNone, all authorization checks should be skipped, so
// unauthorized methods should be callable.
- call, err := client.StartCall(ctx, "mp/server", "Unauthorized", nil, options.VCSecurityNone)
+ call, err := client.StartCall(ctx, "mp/server", "Unauthorized", nil, options.SecurityNone)
if err != nil {
t.Fatalf("client.StartCall failed: %v", err)
}
@@ -1646,7 +1646,7 @@
if err != nil {
t.Fatalf("InternalNewClient failed: %v", err)
}
- call, err := client.StartCall(nil, "foo", "bar", []interface{}{}, options.VCSecurityNone)
+ call, err := client.StartCall(nil, "foo", "bar", []interface{}{}, options.SecurityNone)
if call != nil {
t.Errorf("Expected nil interface got: %#v", call)
}
