veyron/go/src/...: replace "127.0.0.1:0" and "localhost:0" with ":0" in address flag default for binaries, and make sure to override --address to "127.0.0.1:0" in tests (since GCE requires ipv4).
Change-Id: Id12564f3e49fe57807fcf4c224cec8fb5e66c900
diff --git a/tools/application/impl/impl_test.go b/tools/application/impl/impl_test.go
index ddfebdf..94e80be 100644
--- a/tools/application/impl/impl_test.go
+++ b/tools/application/impl/impl_test.go
@@ -80,7 +80,7 @@
t.Errorf("NewServer failed: %v", err)
return nil, nil, err
}
- endpoint, err := server.Listen("tcp", "localhost:0")
+ endpoint, err := server.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Errorf("Listen failed: %v", err)
return nil, nil, err
diff --git a/tools/binary/impl/impl_test.go b/tools/binary/impl/impl_test.go
index f31ceb8..126ce11 100644
--- a/tools/binary/impl/impl_test.go
+++ b/tools/binary/impl/impl_test.go
@@ -89,7 +89,7 @@
t.Errorf("NewServer failed: %v", err)
return nil, nil, err
}
- endpoint, err := server.Listen("tcp", "localhost:0")
+ endpoint, err := server.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Errorf("Listen failed: %v", err)
return nil, nil, err
diff --git a/tools/build/impl/impl_test.go b/tools/build/impl/impl_test.go
index 32a987f..c4bdba1 100644
--- a/tools/build/impl/impl_test.go
+++ b/tools/build/impl/impl_test.go
@@ -34,7 +34,7 @@
if err != nil {
t.Fatalf("NewServer failed: %v", err)
}
- protocol, address := "tcp", "localhost:0"
+ protocol, address := "tcp", "127.0.0.1:0"
endpoint, err := server.Listen(protocol, address)
if err != nil {
t.Fatalf("Listen(%v, %v) failed: %v", protocol, address, err)
diff --git a/tools/identity/googleoauth.go b/tools/identity/googleoauth.go
index 1aedd1f..92421a2 100644
--- a/tools/identity/googleoauth.go
+++ b/tools/identity/googleoauth.go
@@ -20,9 +20,11 @@
// 1. Generate a state token to be included in the HTTP request
// (though, arguably, the random port assignment for the HTTP server is
// enough for XSRF protecetion)
- // 2. Setup an HTTP server which will intercept redirect links from the OAuth flow.
+ // 2. Setup an HTTP server which will intercept redirect links from the OAuth
+ // flow.
// 3. Print out the link for the user to click
- // 4. Return the authorization code obtained from the redirect to the "result" channel.
+ // 4. Return the authorization code obtained from the redirect to the "result"
+ // channel.
var stateBuf [32]byte
if _, err := rand.Read(stateBuf[:]); err != nil {
return nil, fmt.Errorf("failed to generate state token for OAuth: %v", err)
diff --git a/tools/mounttable/impl/impl_test.go b/tools/mounttable/impl/impl_test.go
index 33c9b76..8ec26e6 100644
--- a/tools/mounttable/impl/impl_test.go
+++ b/tools/mounttable/impl/impl_test.go
@@ -60,7 +60,7 @@
t.Errorf("NewServer failed: %v", err)
return nil, nil, err
}
- endpoint, err := server.Listen("tcp", "localhost:0")
+ endpoint, err := server.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Errorf("Listen failed: %v", err)
return nil, nil, err
diff --git a/tools/profile/impl/impl_test.go b/tools/profile/impl/impl_test.go
index 45ccf14..3e600bf 100644
--- a/tools/profile/impl/impl_test.go
+++ b/tools/profile/impl/impl_test.go
@@ -91,7 +91,7 @@
t.Errorf("NewServer failed: %v", err)
return nil, nil, err
}
- endpoint, err := server.Listen("tcp", "localhost:0")
+ endpoint, err := server.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Errorf("Listen failed: %v", err)
return nil, nil, err
diff --git a/tools/proximity/impl/impl_test.go b/tools/proximity/impl/impl_test.go
index 460cd83..7286470 100644
--- a/tools/proximity/impl/impl_test.go
+++ b/tools/proximity/impl/impl_test.go
@@ -53,7 +53,7 @@
t.Errorf("NewServer failed: %v", err)
return nil, nil, err
}
- endpoint, err := server.Listen("tcp", "localhost:0")
+ endpoint, err := server.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Errorf("Listen failed: %v", err)
return nil, nil, err
diff --git a/tools/vrpc/impl/impl_test.go b/tools/vrpc/impl/impl_test.go
index ac5c4c0..54e06f4 100644
--- a/tools/vrpc/impl/impl_test.go
+++ b/tools/vrpc/impl/impl_test.go
@@ -133,7 +133,7 @@
return nil, nil, err
}
- endpoint, err := server.Listen("tcp", "localhost:0")
+ endpoint, err := server.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Errorf("Listen failed: %v", err)
return nil, nil, err
