x/ref: Disallow uppercase acronyms in VDL identifiers.
The purpose of this change is to ensure code in each generated
language is idiomatic and looks reasonable. The problem with
uppercase acronyms is they either look bad or are non-reversible,
when converted to camelCase or CONST_CASE.
E.g. EOF is converted to eOF, which looks bad. MyTTL is
converted to MY_TTL, which is non-reversible.
Const identifiers are currently special-cased to avoid this rule.
In the future we may choose to change to the same rule for const
identifiers; this is less important since const identifiers are
never sent over the wire.
MultiPart: 2/3
Change-Id: I1673c92763bb09257a285c381a256ec2d773ee3c
diff --git a/lib/vdl/codegen/java/file_client_factory.go b/lib/vdl/codegen/java/file_client_factory.go
index 1251bb2..e5d988c 100644
--- a/lib/vdl/codegen/java/file_client_factory.go
+++ b/lib/vdl/codegen/java/file_client_factory.go
@@ -6,6 +6,7 @@
"path"
"v.io/x/ref/lib/vdl/compile"
+ "v.io/x/ref/lib/vdl/vdlutil"
)
const clientFactoryTmpl = `// This file was auto-generated by the veyron vdl tool.
@@ -30,7 +31,7 @@
// genJavaClientFactoryFile generates the Java file containing client bindings for
// all interfaces in the provided package.
func genJavaClientFactoryFile(iface *compile.Interface, env *compile.Env) JavaFileInfo {
- javaServiceName := toUpperCamelCase(iface.Name)
+ javaServiceName := vdlutil.FirstRuneToUpper(iface.Name)
data := struct {
AccessModifier string
Sources string
