ref: Move context.T out of rpc.ServerCall.
The purpose of this change is to make our usage of context.T more
consistent; it was a bit lame that we gave guidance to never wrap
context.T in another type, but were doing it ourselves. The JS
code is also being changed to follow this convention (in separate
CLs), so we'll be consistent between Go and JS as well.
The server implementation used to look like this:
func (*impl) Foo(call rpc.ServerCall, ...)
Now it looks like this:
func (*impl) Foo(ctx *context.T, call rpc.ServerCall, ...)
Also added a ServerCall.Security() function, which returns the
security.Call. The security.Call is still embedded inside
context.T for now; a subsequent change will remove it from
context.T and add an explicit security.Call argument where
necessary. That's a separate CL since some of the choices may be
more controversial, and it's a smaller set of changes.
MultiPart: 2/8
Change-Id: If1ea84b4263836f7ddd82b965c35178a73d314cf
diff --git a/profiles/internal/lib/appcycle/appcycle.go b/profiles/internal/lib/appcycle/appcycle.go
index cb67dec..6012b0c 100644
--- a/profiles/internal/lib/appcycle/appcycle.go
+++ b/profiles/internal/lib/appcycle/appcycle.go
@@ -10,6 +10,7 @@
"sync"
"v.io/v23"
+ "v.io/v23/context"
"v.io/v23/rpc"
"v.io/v23/security"
"v.io/x/lib/vlog"
@@ -125,8 +126,8 @@
return public.AppCycleServer(m.disp)
}
-func (d *invoker) Stop(call public.AppCycleStopServerCall) error {
- blessings, _ := security.RemoteBlessingNames(call.Context())
+func (d *invoker) Stop(ctx *context.T, call public.AppCycleStopServerCall) error {
+ blessings, _ := security.RemoteBlessingNames(ctx)
vlog.Infof("AppCycle Stop request from %v", blessings)
// The size of the channel should be reasonably sized to expect not to
// miss updates while we're waiting for the stream to unblock.
@@ -148,7 +149,7 @@
return nil
}
-func (d *invoker) ForceStop(rpc.ServerCall) error {
+func (d *invoker) ForceStop(*context.T, rpc.ServerCall) error {
d.ac.ForceStop()
return fmt.Errorf("ForceStop should not reply as the process should be dead")
}
