veyron2/vdl: Add typeobject to parser, compiler and go codegen.
A large part of of this CL is renaming from typeval->typeobject.
Note that some support for typeobject already existed; the easy
stuff like supporting the typeobject type in the compiler and
codegen. This CL fills in the holes, adding support for
typeobject constants, and making some minor changes to make this
easier.
I'm particularly pleased with the one weird trick in
codegen/golang/const.go; I'd originally put off adding go codegen
support for typeobject consts because I thought it was lots of
mindless work, but it turns out it's really easy.
Change-Id: I2fdab9d6582ea83c17851d75ffe845bc505e5136
diff --git a/runtimes/google/ipc/benchmarks/service.vdl.go b/runtimes/google/ipc/benchmarks/service.vdl.go
index 127b5d8..806dd55 100644
--- a/runtimes/google/ipc/benchmarks/service.vdl.go
+++ b/runtimes/google/ipc/benchmarks/service.vdl.go
@@ -16,8 +16,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Benchmark is the interface the client binds and uses.
diff --git a/security/agent/pingpong/wire.vdl.go b/security/agent/pingpong/wire.vdl.go
index 5a22289..9bf1574 100644
--- a/security/agent/pingpong/wire.vdl.go
+++ b/security/agent/pingpong/wire.vdl.go
@@ -13,8 +13,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Simple service used in the agent tests.
diff --git a/security/agent/server/wire.vdl.go b/security/agent/server/wire.vdl.go
index 445984a..d9fcc39 100644
--- a/security/agent/server/wire.vdl.go
+++ b/security/agent/server/wire.vdl.go
@@ -15,8 +15,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Agent is the interface the client binds and uses.
diff --git a/services/identity/identity.vdl.go b/services/identity/identity.vdl.go
index 068b53a..85027dc 100644
--- a/services/identity/identity.vdl.go
+++ b/services/identity/identity.vdl.go
@@ -16,8 +16,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// OAuthBlesser exchanges OAuth access tokens for
diff --git a/services/mgmt/debug/debug.vdl.go b/services/mgmt/debug/debug.vdl.go
index 9a98789..96e09d0 100644
--- a/services/mgmt/debug/debug.vdl.go
+++ b/services/mgmt/debug/debug.vdl.go
@@ -19,8 +19,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// This interface exists only for the purpose of generating a valid Signature
diff --git a/services/mgmt/node/config.vdl.go b/services/mgmt/node/config.vdl.go
index 32965b5..5ef274f 100644
--- a/services/mgmt/node/config.vdl.go
+++ b/services/mgmt/node/config.vdl.go
@@ -13,8 +13,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Config is an RPC API to the config service.
diff --git a/services/mgmt/repository/repository.vdl.go b/services/mgmt/repository/repository.vdl.go
index 2ec59c2..57ac530 100644
--- a/services/mgmt/repository/repository.vdl.go
+++ b/services/mgmt/repository/repository.vdl.go
@@ -23,8 +23,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Application describes an application repository internally. Besides
diff --git a/services/mgmt/root/root.vdl.go b/services/mgmt/root/root.vdl.go
index 09c1f3a..273f77b 100644
--- a/services/mgmt/root/root.vdl.go
+++ b/services/mgmt/root/root.vdl.go
@@ -15,8 +15,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Root is an interface to be implemented by a process with root level
diff --git a/services/mounttable/lib/collection_test.vdl.go b/services/mounttable/lib/collection_test.vdl.go
index 77b9710..e31a27d 100644
--- a/services/mounttable/lib/collection_test.vdl.go
+++ b/services/mounttable/lib/collection_test.vdl.go
@@ -13,8 +13,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Collection is the interface the client binds and uses.
diff --git a/services/security/discharger.vdl.go b/services/security/discharger.vdl.go
index 67dddaf..6793150 100644
--- a/services/security/discharger.vdl.go
+++ b/services/security/discharger.vdl.go
@@ -15,8 +15,9 @@
_gen_wiretype "veyron.io/veyron/veyron2/wiretype"
)
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// Discharger is the interface for obtaining discharges for ThirdPartyCaveats.
diff --git a/tools/vrpc/test_base/test_base.vdl.go b/tools/vrpc/test_base/test_base.vdl.go
index bac146f..92bf836 100644
--- a/tools/vrpc/test_base/test_base.vdl.go
+++ b/tools/vrpc/test_base/test_base.vdl.go
@@ -19,8 +19,9 @@
Y int32
}
-// TODO(bprosnitz) Remove this line once signatures are updated to use typevals.
-// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only bootstrap types are used on interfaces.
+// TODO(toddw): Remove this line once the new signature support is done.
+// It corrects a bug where _gen_wiretype is unused in VDL pacakges where only
+// bootstrap types are used on interfaces.
const _ = _gen_wiretype.TypeIDInvalid
// TypeTester is the interface the client binds and uses.
