Merge "{veyron/veyron2}/services/mgmt/build: a simple Go build server"
diff --git a/examples/pipetobrowser/browser/actions/redirect-pipe.js b/examples/pipetobrowser/browser/actions/redirect-pipe.js
index 4d92d73..28ce6d9 100644
--- a/examples/pipetobrowser/browser/actions/redirect-pipe.js
+++ b/examples/pipetobrowser/browser/actions/redirect-pipe.js
@@ -61,9 +61,9 @@
getAllPublishedP2BNames().then((allNames) => {
// append current plugin name to the veyron names for better UX
dialog.existingNames = allNames.map((n) => {
- return n + '/pipe/' + (currentPluginName || ''); //TODO(aghassemi) publish issue
+ return n + (currentPluginName || '');
});
}).catch((e) => {
log.debug('getAllPublishedP2BNames failed', e);
});
-}
\ No newline at end of file
+}
diff --git a/examples/pipetobrowser/browser/services/pipe-to-browser-server.js b/examples/pipetobrowser/browser/services/pipe-to-browser-server.js
index abf7749..cf04487 100644
--- a/examples/pipetobrowser/browser/services/pipe-to-browser-server.js
+++ b/examples/pipetobrowser/browser/services/pipe-to-browser-server.js
@@ -55,7 +55,6 @@
var p2b = {
pipe($suffix, $stream) {
return new Promise(function(resolve, reject) {
-
log.debug('received pipe request for:', $suffix);
var numBytesForThisCall = 0;
@@ -89,12 +88,12 @@
state.publishing = true;
- return server.serve(config.publishNamePrefix + '/' + name + '/pipe', p2b).then((endpoint) => { //TODO(aghassemi) publish-issue
+ return server.serve(config.publishNamePrefix + '/' + name, p2b).then((endpoint) => {
log.debug('published with endpoint:', endpoint);
state.published = true;
state.publishing = false;
- state.fullServiceName = config.publishNamePrefix + '/' + name + '/pipe'; //TODO(aghassemi) publish-issue
+ state.fullServiceName = config.publishNamePrefix + '/' + name;
state.date = new Date();
return endpoint;
diff --git a/runtimes/google/ipc/jni/arg_getter_test.go b/runtimes/google/ipc/jni/arg_getter_test.go
index f5429e4..47efda8 100644
--- a/runtimes/google/ipc/jni/arg_getter_test.go
+++ b/runtimes/google/ipc/jni/arg_getter_test.go
@@ -28,12 +28,9 @@
func TestGetter(t *testing.T) {
iface := "veyron2/vdl/test_base/ServiceB"
- getter := newArgGetter(iface)
- if getter == nil {
- t.Fatalf("no getter for interface: %v ", iface)
- }
- if got, want := getter.vdlPath, iface; got != want {
- t.Errorf("invalid pathname: got %v , want %v ", got, want)
+ getter, err := newArgGetter([]string{iface})
+ if err != nil {
+ t.Fatalf("couldn't find getter for interface: %v ", iface)
}
data := []struct {
Method string
