syncbase: various small additions and enhancements
- stop returning error from Table.Scan
- make app/db/table delete idempotent
- implement Table.DeleteRowRange
- add basic perms check to Table.Scan
- various comment and TODO tweaks
- drop WrapError, use verror.Convert
Change-Id: Ib3d34c14751d39c2c7e324945ab30e347cd07e30
diff --git a/services/syncbase/server/watchable/transaction.go b/services/syncbase/server/watchable/transaction.go
index 1be1b85..ace48de 100644
--- a/services/syncbase/server/watchable/transaction.go
+++ b/services/syncbase/server/watchable/transaction.go
@@ -36,7 +36,7 @@
tx.mu.Lock()
defer tx.mu.Unlock()
if tx.err != nil {
- return valbuf, store.WrapError(tx.err)
+ return valbuf, convertError(tx.err)
}
var err error
if !tx.st.managesKey(key) {
@@ -70,7 +70,7 @@
tx.mu.Lock()
defer tx.mu.Unlock()
if tx.err != nil {
- return store.WrapError(tx.err)
+ return convertError(tx.err)
}
var err error
if !tx.st.managesKey(key) {
@@ -87,7 +87,7 @@
tx.mu.Lock()
defer tx.mu.Unlock()
if tx.err != nil {
- return store.WrapError(tx.err)
+ return convertError(tx.err)
}
var err error
if !tx.st.managesKey(key) {
@@ -104,7 +104,7 @@
tx.mu.Lock()
defer tx.mu.Unlock()
if tx.err != nil {
- return store.WrapError(tx.err)
+ return convertError(tx.err)
}
tx.err = verror.New(verror.ErrBadState, nil, store.ErrMsgCommittedTxn)
tx.st.mu.Lock()
@@ -144,7 +144,7 @@
tx.mu.Lock()
defer tx.mu.Unlock()
if tx.err != nil {
- return store.WrapError(tx.err)
+ return convertError(tx.err)
}
tx.err = verror.New(verror.ErrCanceled, nil, store.ErrMsgAbortedTxn)
return tx.itx.Abort()
