)]}' { "commit": "abab1ecf17cc0945e8896a3b2ac8146a86dd1fb3", "tree": "0e0ec59a30ecb4d440e2cb08885a4cc4283ea195", "parents": [ "8e0bcca7dba8352cede6d686344cc6c92323f18e" ], "author": { "name": "Mike Burrows", "email": "m3b@google.com", "time": "Wed Jul 13 13:00:10 2016 -0700" }, "committer": { "name": "Mike Burrows", "email": "m3b@google.com", "time": "Wed Jul 13 13:00:10 2016 -0700" }, "message": "v.io/x/ref/services/syncbase/vsync: fix flaky TestBlobFetchSimple\n\nI had two errors in TestBlobFetchSimple.\n\nFirst, it was flaky because I ran two test phases back to back using the same\nset of 100 blob ids. The code determines when the first phase is over\nwhen its fake flob fetch routine decrements a test-local counter to zero.\nBut there can be a delay between that routine decrementing its counter,\nand the routine returning to the blob fetching code, which then must record the\nblob as having been fetched successfully.\nIf the second phase starts while there are still fetches that have completed,\nbut not yet been recorded, the blob fetcher\u0027s duplicate elimination\nwill come into play, and unexpectedly ignore some blob fetch requests from the\nsecond phase. This is now fixed by creating new blob ids for each phase.\n\nSecond, I was failing to shutdown the vsync test framework correctly.\nI now call vsync.destroyService().\n\nChange-Id: I91bde063391cbe3b93c3b041f19e0ea6bd4c59a0\n", "tree_diff": [ { "type": "modify", "old_id": "672e487349e6d16711c8591d0fa0b7610488034a", "old_mode": 33188, "old_path": "services/syncbase/vsync/server_blob_fetcher_test.go", "new_id": "21029a850878415ccb744ed55b1227ab83459eb7", "new_mode": 33188, "new_path": "services/syncbase/vsync/server_blob_fetcher_test.go" } ] }