core.go: The vdl "any" type is now generated as go *vdl.Value.
Previously we were generating as vdl.AnyRep, which was another
name for interface{}. There are multiple problems with using
interface{}:
1) Decoding into an "interface{}" requires that the type has
been registered with VDL, and uses our type name based
matching logic. This is error prone; if we happen to change
the package path, the type name changes. And if the type
isn't registered, we'll end up with a *vdl.Value anyways.
Now there's no ambiguity; you always get a *vdl.Value, which
can represent values of all vdl types.
2) Some Go values aren't valid in VDL. E.g. Go values that
contain channels, functions or unsafe pointers are all
invalid. Using *vdl.Value at our API boundaries forces the
callers to make an informed decision.
This is the main portion of a 7-part CL, which removes
vdl.AnyRep, and uses *vdl.Value instead.
MultiPart: 1/7
Change-Id: Ie4f3ab6bce0363f82f53c2315a7435844f6ffe85
diff --git a/runtimes/google/ipc/server.go b/runtimes/google/ipc/server.go
index 85a6f35..84fad16 100644
--- a/runtimes/google/ipc/server.go
+++ b/runtimes/google/ipc/server.go
@@ -18,6 +18,7 @@
"v.io/core/veyron2/options"
"v.io/core/veyron2/security"
"v.io/core/veyron2/services/security/access"
+ "v.io/core/veyron2/vdl"
"v.io/core/veyron2/verror"
"v.io/core/veyron2/vlog"
"v.io/core/veyron2/vom"
@@ -921,7 +922,7 @@
ackBlessings bool
blessings security.Blessings
method, suffix string
- tags []interface{}
+ tags []*vdl.Value
discharges map[string]security.Discharge
starttime time.Time
endStreamArgs bool // are the stream args at EOF?
@@ -1213,8 +1214,8 @@
ipc.ServerContext
}
-func (debugContext) MethodTags() []interface{} {
- return []interface{}{access.Debug}
+func (debugContext) MethodTags() []*vdl.Value {
+ return []*vdl.Value{vdl.ValueOf(access.Debug)}
}
// Send implements the ipc.Stream method.
@@ -1259,7 +1260,7 @@
//nologcall
return fs.method
}
-func (fs *flowServer) MethodTags() []interface{} {
+func (fs *flowServer) MethodTags() []*vdl.Value {
//nologcall
return fs.tags
}
