veyron.io/services/wsprd: Removing items that have errors from glob
results.
Namespace client glob method can return items that have
errors in them. We are removing those items for two reasons:
1- naming.VDLMountEntry does not have the field Error and we want to use
VLD types between JS/WSPR
2- It's quite confusing that every user of glob method needs to know this
fact and most likely needs to act upon items with error considering they
may be completely invalid and not match the pattern even.
Change-Id: Ida6f8165551359133127e55c5d6a062b46bffc48
diff --git a/services/wsprd/namespace/request_handler.go b/services/wsprd/namespace/request_handler.go
index c2f7150..33a2cad 100644
--- a/services/wsprd/namespace/request_handler.go
+++ b/services/wsprd/namespace/request_handler.go
@@ -161,6 +161,17 @@
}
for name := range ch {
+ // TODO(aghassemi)
+ // Namespace client glob method can return items that have
+ // errors in them. We are removing those items for two reasons:
+ // 1- naming.VDLMountEntry does not have the field Error and we want to use
+ // VLD types between JS/WSPR
+ // 2- It's quite confusing that every user of glob method needs to know this
+ // fact and most likely needs to act upon items with error considering they
+ // may be completely invalid and not match the pattern even.
+ if name.Error != nil {
+ continue
+ }
val, err := encodeVom2(convertToVDLEntry(name))
if err != nil {
w.Error(verror2.Make(verror2.Internal, ctx, err))
