commit dc150cd679cc1c779f06a3dba76220316aae2334
author Asim Shankar <ashankar@google.com> Fri Aug 08 10:59:39 2014 -0700
committer Asim Shankar <ashankar@google.com> Fri Aug 08 10:59:40 2014 -0700
tree 8fe6becfb8d68350c9b319d2923ca5edf25b3ee0
parent 8bb9be9d013f28fea4a1e206e7c1fb6b7a233da9

veyron/security/auditor: Rename package to veyron/security/audit.

Motivations:
- Shorter
- It was getting annoying to do things like:
  var auditor auditor.Auditor
  ...
  auditor.Audit(auditor.Entry{})  // would fail because of confusion between the auditor package and auditor variable.

Change-Id: I2fa7576ecb542f4a630bd2a41d6c39b0e3d25797

security/audit/auditor.go

diff --git a/security/auditor/auditor.go b/security/audit/auditor.go
similarity index 88%
rename from security/auditor/auditor.go
rename to security/audit/auditor.go
index 1dcdf0c..9ba5759 100644
--- a/security/auditor/auditor.go
+++ b/security/audit/auditor.go
@@ -1,8 +1,8 @@
-// Package auditor provides mechanisms to write method invocations to an audit log.
+// Package audit provides mechanisms to write method invocations to an audit log.
 //
 // Typical use would be for tracking sensitive operations like private key usage (NewPrivateID),
 // or sensitive RPC method invocations.
-package auditor
+package audit
 
 import "time"
 

security/audit/id.go

diff --git a/security/auditor/id.go b/security/audit/id.go
similarity index 99%
rename from security/auditor/id.go
rename to security/audit/id.go
index 5a7795a..edbcff0 100644
--- a/security/auditor/id.go
+++ b/security/audit/id.go
@@ -1,4 +1,4 @@
-package auditor
+package audit
 
 import (
 	"crypto/ecdsa"

security/audit/id_test.go

diff --git a/security/auditor/id_test.go b/security/audit/id_test.go
similarity index 95%
rename from security/auditor/id_test.go
rename to security/audit/id_test.go
index 6ece0ec..c81da1c 100644
--- a/security/auditor/id_test.go
+++ b/security/audit/id_test.go
@@ -1,4 +1,4 @@
-package auditor_test
+package audit_test
 
 import (
 	"crypto/ecdsa"
@@ -8,7 +8,7 @@
 	"testing"
 	"time"
 
-	"veyron/security/auditor"
+	"veyron/security/audit"
 	"veyron2/naming"
 	"veyron2/security"
 )
@@ -37,7 +37,7 @@
 		mockID      = new(mockID)
 		mockAuditor = new(mockAuditor)
 	)
-	id := auditor.NewPrivateID(mockID, mockAuditor)
+	id := audit.NewPrivateID(mockID, mockAuditor)
 	tests := []struct {
 		Method        string
 		Args          V
@@ -62,7 +62,7 @@
 			t.Errorf("id.%v(%#v) returned (..., %v), want (..., %v)", test.Method, test.Args, got, wantErr)
 		}
 		// Nothing should be audited
-		if audited := mockAuditor.Release(); !reflect.DeepEqual(audited, auditor.Entry{}) {
+		if audited := mockAuditor.Release(); !reflect.DeepEqual(audited, audit.Entry{}) {
 			t.Errorf("id.%v(%#v) resulted in [%+v] being written to the audit log, nothing should have been", test.Method, test.Args, audited)
 		}
 
@@ -96,7 +96,7 @@
 		if audited.Timestamp.Before(now) || audited.Timestamp.IsZero() {
 			t.Errorf("id.%v(%#v) audited the time as %v, should have been a time after %v", test.Method, test.Args, audited.Timestamp, now)
 		}
-		if want := (auditor.Entry{
+		if want := (audit.Entry{
 			Method:    test.Method,
 			Arguments: []interface{}(test.Args),
 			Results:   []interface{}{test.AuditedResult},
@@ -150,11 +150,11 @@
 func (id *mockID) PublicKey() *ecdsa.PublicKey { return id.publicKey }
 
 type mockAuditor struct {
-	LastEntry auditor.Entry
+	LastEntry audit.Entry
 	NextError error
 }
 
-func (a *mockAuditor) Audit(entry auditor.Entry) error {
+func (a *mockAuditor) Audit(entry audit.Entry) error {
 	if a.NextError != nil {
 		err := a.NextError
 		a.NextError = nil
@@ -164,9 +164,9 @@
 	return nil
 }
 
-func (a *mockAuditor) Release() auditor.Entry {
+func (a *mockAuditor) Release() audit.Entry {
 	entry := a.LastEntry
-	a.LastEntry = auditor.Entry{}
+	a.LastEntry = audit.Entry{}
 	return entry
 }