veyron/services/mgmt/binary/impl: test binary server should not publish.
I investigated my suspicion from reviewing go/vcl/3050 earlier today, and
it's indeed incorrect to call Serve with a non-empty name given the
setup we have there. It happens to work because in the end we connect
directly using the endpoint, but the publish itself was failing and
spewing log errors.
Change-Id: I38592803fadd0de4dd05a81b80272c7416934d07
diff --git a/services/mgmt/binary/impl/impl_test.go b/services/mgmt/binary/impl/impl_test.go
index beaeb35..fbe84b1 100644
--- a/services/mgmt/binary/impl/impl_test.go
+++ b/services/mgmt/binary/impl/impl_test.go
@@ -110,11 +110,11 @@
if err != nil {
t.Fatalf("Listen(%v, %v) failed: %v", protocol, hostname, err)
}
- suffix := "test"
- if err := server.Serve(suffix, dispatcher); err != nil {
- t.Fatalf("Serve(%v) failed: %v", suffix, err)
+ dontPublishName := ""
+ if err := server.Serve(dontPublishName, dispatcher); err != nil {
+ t.Fatalf("Serve(%q) failed: %v", dontPublishName, err)
}
- name := naming.JoinAddressName(endpoint.String(), suffix)
+ name := naming.JoinAddressName(endpoint.String(), "//test")
binary, err := repository.BindBinary(name)
if err != nil {
t.Fatalf("BindBinary(%v) failed: %v", name, err)
