"core": Makes Tests pass under agent
This is part 1 out of n of a series of CLs to make all go tests
pass when they run under an agent (for e.g., inside vbash)
This CL fixes all tests under "veyron/runtimes/google/..."
Most tests currenly fail because of the following pattern:
func TextXXX(t *testing.T) {
runtime, err := rt.New() // In the new world this is veyron2.Init()
ctx := runtime.NewContext()
doSomething(ctx)
...
}
The issue here is that rt.New (or veyron2.Init) initializes the
principal via the environment variables (for e.g., when run inside
vbash, the test initializes its principal through the agent). This is
a problem for multiple reasons:
- the test is not self-contained
- the test can pollute the environment provided principal's state
- the test was likely written with the assumption that rt.New() always
generates a self-signed principal which is False.
To fix this, I am changing the code to:
func TextXXX(t *testing.T) {
runtime, err := rt.New() // In the new world this is veyron2.Init()
ctx := runtime.NewContext()
ctx, err = veyron2.SetPrincipal(tsecurity.NewPrincipal(...))
doSomething(ctx)
...
}
Change-Id: I2d427f4284b87e206057011f88f88575c0868af3
diff --git a/runtimes/google/ipc/simple_test.go b/runtimes/google/ipc/simple_test.go
index 39b1147..15b2a3b 100644
--- a/runtimes/google/ipc/simple_test.go
+++ b/runtimes/google/ipc/simple_test.go
@@ -67,11 +67,13 @@
}
func TestSimpleRPC(t *testing.T) {
- name, fn := initServer(t, gctx)
+ ctx, shutdown := newCtx()
+ defer shutdown()
+ name, fn := initServer(t, ctx)
defer fn()
- client := veyron2.GetClient(r.NewContext())
- call, err := client.StartCall(r.NewContext(), name, "Ping", nil)
+ client := veyron2.GetClient(ctx)
+ call, err := client.StartCall(ctx, name, "Ping", nil)
if err != nil {
t.Fatalf("unexpected error: %s", err)
}
@@ -87,12 +89,13 @@
}
func TestSimpleStreaming(t *testing.T) {
- name, fn := initServer(t, gctx)
+ ctx, shutdown := newCtx()
+ defer shutdown()
+ name, fn := initServer(t, ctx)
defer fn()
- ctx := r.NewContext()
inc := 1
- call, err := veyron2.GetClient(r.NewContext()).StartCall(ctx, name, "Inc", []interface{}{inc})
+ call, err := veyron2.GetClient(ctx).StartCall(ctx, name, "Inc", []interface{}{inc})
if err != nil {
t.Fatalf("unexpected error: %s", err)
}
