core.js: Removing some TODOs that were done or won't get done.
Change-Id: I58b1e5d6a06e176a0851b7c5751ca9b7545ad47a
diff --git a/go/src/v.io/x/js.core/test_service/error_thrower.vdl b/go/src/v.io/x/js.core/test_service/error_thrower.vdl
index cb0da7a..07d16cd 100644
--- a/go/src/v.io/x/js.core/test_service/error_thrower.vdl
+++ b/go/src/v.io/x/js.core/test_service/error_thrower.vdl
@@ -35,7 +35,4 @@
// Throws custom error created by using Standard
ThrowCustomStandardError() error
-
- // Lists all errors Ids available in v23/verror
- ListAllBuiltInErrorIds() ([]string | error)
}
diff --git a/go/src/v.io/x/js.core/test_service/error_thrower.vdl.go b/go/src/v.io/x/js.core/test_service/error_thrower.vdl.go
index c8d337d..75d39fc 100644
--- a/go/src/v.io/x/js.core/test_service/error_thrower.vdl.go
+++ b/go/src/v.io/x/js.core/test_service/error_thrower.vdl.go
@@ -39,8 +39,6 @@
ThrowGoError(*context.T, ...rpc.CallOpt) error
// Throws custom error created by using Standard
ThrowCustomStandardError(*context.T, ...rpc.CallOpt) error
- // Lists all errors Ids available in v23/verror
- ListAllBuiltInErrorIds(*context.T, ...rpc.CallOpt) ([]string, error)
}
// ErrorThrowerClientStub adds universal methods to ErrorThrowerClientMethods.
@@ -108,11 +106,6 @@
return
}
-func (c implErrorThrowerClientStub) ListAllBuiltInErrorIds(ctx *context.T, opts ...rpc.CallOpt) (o0 []string, err error) {
- err = v23.GetClient(ctx).Call(ctx, c.name, "ListAllBuiltInErrorIds", nil, []interface{}{&o0}, opts...)
- return
-}
-
// ErrorThrowerServerMethods is the interface a server writer
// implements for ErrorThrower.
//
@@ -138,8 +131,6 @@
ThrowGoError(*context.T, rpc.ServerCall) error
// Throws custom error created by using Standard
ThrowCustomStandardError(*context.T, rpc.ServerCall) error
- // Lists all errors Ids available in v23/verror
- ListAllBuiltInErrorIds(*context.T, rpc.ServerCall) ([]string, error)
}
// ErrorThrowerServerStubMethods is the server interface containing
@@ -217,10 +208,6 @@
return s.impl.ThrowCustomStandardError(ctx, call)
}
-func (s implErrorThrowerServerStub) ListAllBuiltInErrorIds(ctx *context.T, call rpc.ServerCall) ([]string, error) {
- return s.impl.ListAllBuiltInErrorIds(ctx, call)
-}
-
func (s implErrorThrowerServerStub) Globber() *rpc.GlobState {
return s.gs
}
@@ -278,12 +265,5 @@
Name: "ThrowCustomStandardError",
Doc: "// Throws custom error created by using Standard",
},
- {
- Name: "ListAllBuiltInErrorIds",
- Doc: "// Lists all errors Ids available in v23/verror",
- OutArgs: []rpc.ArgDesc{
- {"", ``}, // []string
- },
- },
},
}
diff --git a/go/src/v.io/x/js.core/test_service/test_serviced/error_thrower_impl.go b/go/src/v.io/x/js.core/test_service/test_serviced/error_thrower_impl.go
index a12cb04..cd7f622 100644
--- a/go/src/v.io/x/js.core/test_service/test_serviced/error_thrower_impl.go
+++ b/go/src/v.io/x/js.core/test_service/test_serviced/error_thrower_impl.go
@@ -61,12 +61,3 @@
func (e *errorThrowerImpl) ThrowCustomStandardError(ctx *context.T, _ rpc.ServerCall) error {
return verror.New(customError, ctx)
}
-
-func (e *errorThrowerImpl) ListAllBuiltInErrorIds(*context.T, rpc.ServerCall) ([]string, error) {
- // TODO(aghassemi) Use when we have enum for error IDs in IDL
- // This is not used yet but the idea is to pass all error types in v23/verror to
- // JavaScript so if a new one is added, this test would break and we add the new one to
- // JavaScript as well. There is no way to enumerate all error IDs right now since they
- // are constants and not an Enum. Enum support is coming later.
- return nil, nil
-}
diff --git a/test/integration/test-server-stop.js b/test/integration/test-server-stop.js
index c107683..f652150 100644
--- a/test/integration/test-server-stop.js
+++ b/test/integration/test-server-stop.js
@@ -54,10 +54,6 @@
});
});
-// TODO(jasoncampbell): At the time this was written the callback case
-// triggered some hard to trackdown error cases, come back and fix it after
-// the tests get ported: https://paste.googleplex.com/5916393484582912
-// TODO(aghassemi) Look into this.
test('Test re-serving a stopped JS service - ' +
'server.stop(callback), runtime.serve(callback)', function(assert) {
serve(name, dispatcher, function(err, res) {
