commit 0f3bdecb5c5496272b9c144f34381ab63cba159c
author Benjamin Prosnitz <bprosnitz@google.com> Mon May 11 22:55:49 2015 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon May 11 22:55:50 2015 +0000
tree 9b1b06f121aa10d89af79a6c12d4f177e6d46f79
parent 1882a8d82b5e5a1219ac7062e97b879600bcaff9
parent 3ffdaac600e28dff437de741fd91807cd8b26656

Merge "ext: Switch to open caveat validation tab when one is already open"

extension/src/background/auth-handler.js

diff --git a/extension/src/background/auth-handler.js b/extension/src/background/auth-handler.js
index 848e7eb..601f280 100644
--- a/extension/src/background/auth-handler.js
+++ b/extension/src/background/auth-handler.js
@@ -127,8 +127,19 @@
 // Pop up a new tab asking the user to chose their caveats.
 AuthHandler.prototype.getCaveats = function(account, origin, appPort) {
   var outstandingAuthRequests = this._outstandingAuthRequests;
+  var caveatTabOrigins = this._caveatTabOrigins;
   if (origin in this._outstandingAuthRequests) {
     outstandingAuthRequests[origin].push(appPort);
+
+    // Switch to the corresponding open caveat tab.
+    for (var tabId in caveatTabOrigins) {
+      if (caveatTabOrigins[tabId] === origin) {
+        var tabIdAsNumber = +tabId;
+        chrome.tabs.update(tabIdAsNumber, {active: true});
+        break;
+      }
+    }
+
     return;
   }
 
@@ -141,7 +152,6 @@
 
   // Get  currently active tab in the window.
   var windowId = appPort.sender.tab.windowId;
-  var caveatTabOrigins = this._caveatTabOrigins;
   chrome.tabs.query({active: true, windowId: windowId}, function(tabs) {
     // Store the current tab id so we can switch back to it after the addcaveats
     // tab is removed.  Note that the currently active tab might not be the same