tree f6565fba053c3dbee457ed8183cd435fb61c2988
parent 3875f46123533b22f0d54354c7e0d4f2ba1c3ad7
author Alex Fandrianto <alexfandrianto@google.com> 1431454717 -0700
committer Alex Fandrianto <alexfandrianto@google.com> 1431454790 -0700

js/core: Extension Caveat tab race fix

Fix race with the account name.
By "locking" early (not in a callback) and setting the account name
immediately, we ensure that any later getCaveats calls will reuse the
same outstanding request tab.

Removed unnecessary the authState flag and corresponding check.
Was this needed? It's a random value, so any (racing) tabs
won't know it's actual value. We also have requestId if we need things
to be unique.

Removed unnecessary _lastRequestId and requestId. The former was an
internal tracking variable that was unused. The latter was sent in
the url, but was also unused.

(Tested on HelloPeer using the build-dev extension.)

Change-Id: I2e9fd7dac3191c3e3c91b5e49aaf6d5cf24eaa42