commit | 1383ca38c8f35afce9ec0abdaa34b40c7e52766d | [log] [tgz] |
---|---|---|
author | Adam Sadovsky <asadovsky@gmail.com> | Thu Jan 14 14:37:19 2016 -0800 |
committer | Adam Sadovsky <asadovsky@gmail.com> | Thu Jan 14 14:37:19 2016 -0800 |
tree | f70dff5f95abbc0df7e77463614cb074a41ef87f | |
parent | 5b9b42880dbb53060940dd4bbddcc7fad133a38c [diff] |
playground: gosh: address TODOs More specifically: - Eliminates Shell.Main, since it's easy enough to use Shell.Fn and set the returned Cmd's Args - Renames Shell.Fn to Shell.FuncCmd - Extends Shell.{Cmd,FuncCmd} comments to explain what's done with the given arguments - Makes it so NewShell takes a snapshot of os.Environ() and uses that henceforth - Makes it so NewShell filters out any gosh env vars coming from outside - Renames registry.go's Fn to Func, Register to RegisterFunc, and Call to CallFunc - Adjusts the behavior of RegisterFunc so that names are augmented to produce collision-resistant handles of the form "file:line:name" - Makes callFunc and Func.call private for now, until there's a clear need for them to be exported - Eliminates gosh.Run - Renames Cmd.Shutdown (which we decided to keep) to Cmd.Terminate - Changes Cmd.Signal and Cmd.Terminate to fail if Wait has been called - Drops Cmd.Kill; if it proves necessary, we'll add a gosh.Kill implementation of os.Signal that tells Cmd.Signal and Cmd.Terminate to issue Process.Kill Also, updates v23test: - Same changes as in gosh (Fn->FuncCmd, no more Main) - Replaces v23test.Run with TestMain (simple case) and InitTestMain (advanced case) - Eliminates the hack with credentials env vars MultiPart: 7/8 Change-Id: I2888c1bcc05ca61b95874944d0f667a0befabf1c
This repository contains the Vanadium project playground.