Remove time.Deadline 0 value semantics.
[See below about a bugfix attached to this CL]
As a recap, time.Deadline is a native type representing deadlines
using an absolute time, while time.WireDeadline is a wire type
representing deadlines using a relative duration from now.
In both old and new code, the native time.Deadline indicates "no
deadline" using time.Time.IsZero().
The old code set WireDeadline.NoDeadline to indicate the "no
deadline" case. This is bad, since it means the zero-value
semantics are different between the native and wire types, which
is annoying for VDL/VOM.
The new code removes the WireDeadline.NoDeadline field, and
instead uses WireDeadline.FromNow=0 as a sentry to indicate "no
deadline". This leaves open a tiny (but non-zero) possibility
that new binaries will interpret old binaries incorrectly. But
that seems fine for now; even if it happens, it shouldn't have a
big impact.
[BUGFIX]
Annoyingly this exposed a bug in the old generated decoders. We
need to return the special-case vdl.ErrFieldNoExist when
encountering non-existent fields, in order for backwards
compatibility to work for unknown struct fields. But we
weren't. This CL also fixes that bug.
MultiPart: 2/4
Change-Id: I8d63c9ce48dad42b934b92be146e0c56fdab1266
diff --git a/test/fortune/fortune.vdl.go b/test/fortune/fortune.vdl.go
index 97ecbce..292ee80 100644
--- a/test/fortune/fortune.vdl.go
+++ b/test/fortune/fortune.vdl.go
@@ -158,7 +158,7 @@
target, err := &t.listTarget, error(nil)
return nil, target, err
default:
- return nil, nil, fmt.Errorf("field %s not in struct v.io/x/jni/test/fortune.ComplexErrorParam", name)
+ return nil, nil, vdl.ErrFieldNoExist
}
}
func (t *ComplexErrorParamTarget) FinishField(_, _ vdl.Target) error {
@@ -176,7 +176,7 @@
t.Value.List = []uint32(nil)
return nil
default:
- return fmt.Errorf("field %s not in struct v.io/x/jni/test/fortune.ComplexErrorParam", name)
+ return vdl.ErrFieldNoExist
}
}
func (t *ComplexErrorParamTarget) FinishFields(_ vdl.FieldsTarget) error {
