blob: 12c6f8de79fd3adb3bf1081a6076f043f94cfb4f [file] [log] [blame]
// Copyright 2015 The Vanadium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package vsync
// Tests for syncgroup management and storage in Syncbase.
import (
"reflect"
"testing"
"time"
wire "v.io/v23/services/syncbase"
_ "v.io/x/ref/runtime/factories/generic"
"v.io/x/ref/services/syncbase/server/interfaces"
"v.io/x/ref/services/syncbase/store/watchable"
)
// checkSGStats verifies syncgroup stats.
func checkSGStats(t *testing.T, svc *mockService, which string, numSG, numMembers int) {
memberViewTTL = 0 // Always recompute the syncgroup membership view.
svc.sync.refreshMembersIfExpired(nil)
view := svc.sync.allMembers
if num := len(view.members); num != numMembers {
t.Errorf("num-members (%s): got %v instead of %v", which, num, numMembers)
}
sgids := make(map[interfaces.GroupId]bool)
for _, info := range view.members {
for _, sgmi := range info.db2sg {
for gid := range sgmi {
sgids[gid] = true
}
}
}
if num := len(sgids); num != numSG {
t.Errorf("num-syncgroups (%s): got %v instead of %v", which, num, numSG)
}
}
// TestAddSyncgroup tests adding syncgroups.
func TestAddSyncgroup(t *testing.T) {
// Set a large value to prevent the syncer from running. Since this
// test adds a fake syncgroup, if the syncer runs, it will attempt
// to initiate using this fake and partial syncgroup data.
peerSyncInterval = 1 * time.Hour
svc := createService(t)
defer destroyService(t, svc)
st := createDatabase(t, svc).St()
s := svc.sync
checkSGStats(t, svc, "add-1", 0, 0)
// Add a syncgroup.
sgId := wire.Id{Name: "foobar", Blessing: "foobarB"}
version := "v111"
sg := &interfaces.Syncgroup{
Id: sgId,
DbId: mockDbId,
Creator: "mockCreator",
SpecVersion: "etag-0",
Spec: wire.SyncgroupSpec{
Collections: []wire.Id{makeCxId("foo"), makeCxId("bar")},
Perms: mockSgPerms,
},
Joiners: map[string]wire.SyncgroupMemberInfo{
"phone": wire.SyncgroupMemberInfo{SyncPriority: 10},
"tablet": wire.SyncgroupMemberInfo{SyncPriority: 25},
"cloud": wire.SyncgroupMemberInfo{SyncPriority: 1},
},
}
tx := st.NewWatchableTransaction()
if err := s.addSyncgroup(nil, tx, version, true, "", nil, s.id, 1, 1, sg); err != nil {
t.Errorf("cannot add syncgroup %v: %v", sg.Id, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit adding syncgroup %v: %v", sg.Id, err)
}
// Verify syncgroup ID, name, and data.
id := SgIdToGid(mockDbId, sgId)
sgOut, err := getSyncgroupByGid(nil, st, id)
if err != nil {
t.Errorf("cannot get syncgroup by ID %s: %v", id, err)
}
if !reflect.DeepEqual(sgOut, sg) {
t.Errorf("invalid syncgroup data for group ID %s: got %v instead of %v", id, sgOut, sg)
}
sgOut, err = getSyncgroupByGid(nil, st, id)
if err != nil {
t.Errorf("cannot get syncgroup by Name %v: %v", sgId, err)
}
if !reflect.DeepEqual(sgOut, sg) {
t.Errorf("invalid syncgroup data for group name %v: got %v instead of %v", sgId, sgOut, sg)
}
// Verify membership data.
// Force a rescan of membership data.
s.allMembers = nil
expMembers := map[string]uint32{"phone": 1, "tablet": 1, "cloud": 1}
members := svc.sync.getMembers(nil)
if !reflect.DeepEqual(members, expMembers) {
t.Errorf("invalid syncgroup members: got %v instead of %v", members, expMembers)
}
view := svc.sync.allMembers
for mm := range members {
mi := view.members[mm]
if mi == nil {
t.Errorf("cannot get info for syncgroup member %s", mm)
}
if len(mi.db2sg) != 1 {
t.Errorf("invalid info for syncgroup member %s: %v", mm, mi)
}
var sgmi sgMemberInfo
for _, v := range mi.db2sg {
sgmi = v
break
}
if len(sgmi) != 1 {
t.Errorf("invalid member info for syncgroup member %s: %v", mm, sgmi)
}
expJoinerInfo := sg.Joiners[mm]
joinerInfo := sgmi[id]
if !reflect.DeepEqual(joinerInfo, expJoinerInfo) {
t.Errorf("invalid Info for syncgroup member %s in group ID %s: got %v instead of %v",
mm, id, joinerInfo, expJoinerInfo)
}
}
checkSGStats(t, svc, "add-2", 1, 3)
// Adding a syncgroup for a pre-existing name should fail.
tx = st.NewWatchableTransaction()
if err = s.addSyncgroup(nil, tx, NoVersion, true, "", nil, s.id, 3, 3, sg); err == nil {
t.Errorf("re-adding the same syncgroup name %v did not fail", sgId)
}
tx.Abort()
checkSGStats(t, svc, "add-3", 1, 3)
// Fetch a non-existing syncgroup by ID or name should fail.
badSgId := wire.Id{Name: "not-available", Blessing: "naB"}
badId := interfaces.GroupId("999")
if sg, err := getSyncgroupByGid(nil, st, SgIdToGid(mockDbId, badSgId)); err == nil {
t.Errorf("found non-existing syncgroup name %s: got %v", badSgId, sg)
}
if sg, err := getSyncgroupByGid(nil, st, badId); err == nil {
t.Errorf("found non-existing syncgroup ID %s: got %v", badId, sg)
}
}
// TestInvalidAddSyncgroup tests adding syncgroups.
func TestInvalidAddSyncgroup(t *testing.T) {
// Set a large value to prevent the threads from firing.
peerSyncInterval = 1 * time.Hour
svc := createService(t)
defer destroyService(t, svc)
st := createDatabase(t, svc).St()
s := svc.sync
checkBadAddSyncgroup := func(t *testing.T, st *watchable.Store, sg *interfaces.Syncgroup, msg string) {
tx := st.NewWatchableTransaction()
if err := s.addSyncgroup(nil, tx, NoVersion, true, "", nil, s.id, 1, 1, sg); err == nil {
t.Errorf("checkBadAddSyncgroup: adding bad syncgroup (%s) did not fail", msg)
}
tx.Abort()
}
checkBadAddSyncgroup(t, st, nil, "nil SG")
mkSg := func() *interfaces.Syncgroup {
return &interfaces.Syncgroup{
Id: wire.Id{Name: "foobar", Blessing: "foobarB"},
DbId: mockDbId,
Creator: "mockCreator",
SpecVersion: "etag-0",
Spec: wire.SyncgroupSpec{
Collections: []wire.Id{makeCxId("foo"), makeCxId("bar")},
Perms: mockSgPerms,
},
Joiners: map[string]wire.SyncgroupMemberInfo{
"phone": wire.SyncgroupMemberInfo{SyncPriority: 10},
"tablet": wire.SyncgroupMemberInfo{SyncPriority: 25},
"cloud": wire.SyncgroupMemberInfo{SyncPriority: 1},
},
}
}
sg := mkSg()
sg.Id.Name = ""
checkBadAddSyncgroup(t, st, sg, "SG w/o name")
sg = mkSg()
sg.DbId = wire.Id{}
checkBadAddSyncgroup(t, st, sg, "SG w/o DbId")
sg = mkSg()
sg.DbId = wire.Id{Blessing: "foo"}
checkBadAddSyncgroup(t, st, sg, "SG with invalid (empty Name) DbId")
sg = mkSg()
sg.DbId = wire.Id{Name: "bar"}
checkBadAddSyncgroup(t, st, sg, "SG with invalid (empty Blessing) DbId")
sg = mkSg()
sg.Creator = ""
checkBadAddSyncgroup(t, st, sg, "SG w/o creator")
sg = mkSg()
sg.SpecVersion = ""
checkBadAddSyncgroup(t, st, sg, "SG w/o Version")
sg = mkSg()
sg.Joiners = nil
checkBadAddSyncgroup(t, st, sg, "SG w/o Joiners")
sg = mkSg()
sg.Spec.Collections = nil
checkBadAddSyncgroup(t, st, sg, "SG w/o Collections")
sg = mkSg()
sg.Spec.Collections = []wire.Id{makeCxId("foo"), makeCxId("bar"), makeCxId("foo")}
checkBadAddSyncgroup(t, st, sg, "SG with duplicate collections")
sg = mkSg()
sg.Spec.Collections = []wire.Id{wire.Id{}}
checkBadAddSyncgroup(t, st, sg, "SG with invalid (empty) collection id")
sg = mkSg()
sg.Spec.Collections = []wire.Id{wire.Id{Blessing: "foo"}}
checkBadAddSyncgroup(t, st, sg, "SG with invalid (empty Name) collection id")
sg = mkSg()
sg.Spec.Collections = []wire.Id{wire.Id{Name: "bar"}}
checkBadAddSyncgroup(t, st, sg, "SG with invalid (empty Blessing) collection id")
}
// TestDeleteSyncgroup tests deleting a syncgroup.
func TestDeleteSyncgroup(t *testing.T) {
// Set a large value to prevent the threads from firing.
peerSyncInterval = 1 * time.Hour
svc := createService(t)
defer destroyService(t, svc)
st := createDatabase(t, svc).St()
s := svc.sync
sgIdWire := wire.Id{Name: "foobar", Blessing: "foobarB"}
sgIdInternal := SgIdToGid(mockDbId, sgIdWire)
// Delete non-existing syncgroups.
tx := st.NewWatchableTransaction()
if err := delSyncgroupByGid(nil, nil, tx, sgIdInternal); err == nil {
t.Errorf("deleting a non-existing syncgroup ID did not fail")
}
if err := delSyncgroupBySgId(nil, nil, tx, mockDbId, sgIdWire); err == nil {
t.Errorf("deleting a non-existing syncgroup name did not fail")
}
tx.Abort()
checkSGStats(t, svc, "del-1", 0, 0)
// Create the syncgroup to delete later.
sg := &interfaces.Syncgroup{
Id: sgIdWire,
DbId: mockDbId,
Creator: "mockCreator",
SpecVersion: "etag-0",
Spec: wire.SyncgroupSpec{
Collections: []wire.Id{makeCxId("foo"), makeCxId("bar")},
Perms: mockSgPerms,
},
Joiners: map[string]wire.SyncgroupMemberInfo{
"phone": wire.SyncgroupMemberInfo{SyncPriority: 10},
"tablet": wire.SyncgroupMemberInfo{SyncPriority: 25},
"cloud": wire.SyncgroupMemberInfo{SyncPriority: 1},
},
}
tx = st.NewWatchableTransaction()
if err := s.addSyncgroup(nil, tx, NoVersion, true, "", nil, s.id, 1, 1, sg); err != nil {
t.Errorf("creating syncgroup ID %s failed: %v", sgIdInternal, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit adding syncgroup ID %s: %v", sgIdInternal, err)
}
checkSGStats(t, svc, "del-2", 1, 3)
// Delete it by ID.
tx = st.NewWatchableTransaction()
if err := delSyncgroupByGid(nil, nil, tx, sgIdInternal); err != nil {
t.Errorf("deleting syncgroup ID %s failed: %v", sgIdInternal, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit deleting syncgroup ID %s: %v", sgIdInternal, err)
}
checkSGStats(t, svc, "del-3", 0, 0)
// Create it again, update it, then delete it by name.
tx = st.NewWatchableTransaction()
if err := s.addSyncgroup(nil, tx, NoVersion, true, "", nil, s.id, 2, 2, sg); err != nil {
t.Errorf("creating syncgroup ID %s after delete failed: %v", sgIdInternal, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit adding syncgroup ID %s after delete: %v", sgIdInternal, err)
}
tx = st.NewWatchableTransaction()
if err := s.updateSyncgroupVersioning(nil, tx, sgIdInternal, NoVersion, true, s.id, 3, 3, sg); err != nil {
t.Errorf("updating syncgroup ID %s version: %v", sgIdInternal, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit updating syncgroup ID %s version: %v", sgIdInternal, err)
}
checkSGStats(t, svc, "del-4", 1, 3)
tx = st.NewWatchableTransaction()
if err := delSyncgroupBySgId(nil, nil, tx, mockDbId, sgIdWire); err != nil {
t.Errorf("deleting syncgroup name %s failed: %v", sgIdWire, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit deleting syncgroup name %s: %v", sgIdWire, err)
}
checkSGStats(t, svc, "del-5", 0, 0)
}
// TestMultiSyncgroups tests creating multiple syncgroups.
func TestMultiSyncgroups(t *testing.T) {
// Set a large value to prevent the threads from firing.
peerSyncInterval = 1 * time.Hour
svc := createService(t)
defer destroyService(t, svc)
st := createDatabase(t, svc).St()
s := svc.sync
sgIdWire1, sgIdWire2 := wire.Id{Name: "foo", Blessing: "fooB"}, wire.Id{Name: "bar", Blessing: "barB"}
sgIdInternal1, sgIdInternal2 := SgIdToGid(mockDbId, sgIdWire1), SgIdToGid(mockDbId, sgIdWire2)
// Add two syncgroups.
sg1 := &interfaces.Syncgroup{
Id: sgIdWire1,
DbId: mockDbId,
Creator: "mockCreator",
SpecVersion: "etag-1",
Spec: wire.SyncgroupSpec{
MountTables: []string{"mt1"},
Collections: []wire.Id{makeCxId("foo")},
Perms: mockSgPerms,
},
Joiners: map[string]wire.SyncgroupMemberInfo{
"phone": wire.SyncgroupMemberInfo{SyncPriority: 10},
"tablet": wire.SyncgroupMemberInfo{SyncPriority: 25},
"cloud": wire.SyncgroupMemberInfo{SyncPriority: 1},
},
}
sg2 := &interfaces.Syncgroup{
Id: sgIdWire2,
DbId: mockDbId,
Creator: "mockCreator",
SpecVersion: "etag-2",
Spec: wire.SyncgroupSpec{
MountTables: []string{"mt2", "mt3"},
Collections: []wire.Id{makeCxId("bar")},
Perms: mockSgPerms,
},
Joiners: map[string]wire.SyncgroupMemberInfo{
"tablet": wire.SyncgroupMemberInfo{SyncPriority: 111},
"door": wire.SyncgroupMemberInfo{SyncPriority: 33},
"lamp": wire.SyncgroupMemberInfo{SyncPriority: 9},
},
}
tx := st.NewWatchableTransaction()
if err := s.addSyncgroup(nil, tx, NoVersion, true, "", nil, s.id, 1, 1, sg1); err != nil {
t.Errorf("creating syncgroup ID %s failed: %v", sgIdInternal1, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit adding syncgroup ID %s: %v", sgIdInternal1, err)
}
checkSGStats(t, svc, "multi-1", 1, 3)
tx = st.NewWatchableTransaction()
if err := s.addSyncgroup(nil, tx, NoVersion, true, "", nil, s.id, 2, 2, sg2); err != nil {
t.Errorf("creating syncgroup ID %s failed: %v", sgIdInternal2, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit adding syncgroup ID %s: %v", sgIdInternal2, err)
}
checkSGStats(t, svc, "multi-2", 2, 5)
// Verify membership data.
expMembers := map[string]uint32{"phone": 1, "tablet": 2, "cloud": 1, "door": 1, "lamp": 1}
members := svc.sync.getMembers(nil)
if !reflect.DeepEqual(members, expMembers) {
t.Errorf("invalid syncgroup members: got %v instead of %v", members, expMembers)
}
mt2and3 := map[string]struct{}{
"mt2": struct{}{},
"mt3": struct{}{},
}
expMemberInfo := map[string]*memberInfo{
"phone": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal1: sg1.Joiners["phone"],
},
},
mtTables: map[string]struct{}{"mt1": struct{}{}},
},
"tablet": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal1: sg1.Joiners["tablet"],
sgIdInternal2: sg2.Joiners["tablet"],
},
},
mtTables: map[string]struct{}{
"mt1": struct{}{},
"mt2": struct{}{},
"mt3": struct{}{},
},
},
"cloud": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal1: sg1.Joiners["cloud"],
},
},
mtTables: map[string]struct{}{"mt1": struct{}{}},
},
"door": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal2: sg2.Joiners["door"],
},
},
mtTables: mt2and3,
},
"lamp": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal2: sg2.Joiners["lamp"],
},
},
mtTables: mt2and3,
},
}
view := svc.sync.allMembers
for mm := range members {
mi := view.members[mm]
if mi == nil {
t.Errorf("cannot get info for syncgroup member %s", mm)
}
expInfo := expMemberInfo[mm]
if !reflect.DeepEqual(mi, expInfo) {
t.Errorf("invalid Info for syncgroup member %s: got %#v instead of %#v", mm, mi, expInfo)
}
}
// Delete the 1st syncgroup.
tx = st.NewWatchableTransaction()
if err := delSyncgroupByGid(nil, nil, tx, sgIdInternal1); err != nil {
t.Errorf("deleting syncgroup ID %s failed: %v", sgIdInternal1, err)
}
if err := tx.Commit(); err != nil {
t.Errorf("cannot commit deleting syncgroup ID %s: %v", sgIdInternal1, err)
}
checkSGStats(t, svc, "multi-3", 1, 3)
// Verify syncgroup membership data.
expMembers = map[string]uint32{"tablet": 1, "door": 1, "lamp": 1}
members = svc.sync.getMembers(nil)
if !reflect.DeepEqual(members, expMembers) {
t.Errorf("invalid syncgroup members: got %v instead of %v", members, expMembers)
}
expMemberInfo = map[string]*memberInfo{
"tablet": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal2: sg2.Joiners["tablet"],
},
},
mtTables: mt2and3,
},
"door": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal2: sg2.Joiners["door"],
},
},
mtTables: mt2and3,
},
"lamp": &memberInfo{
db2sg: map[wire.Id]sgMemberInfo{
mockDbId: sgMemberInfo{
sgIdInternal2: sg2.Joiners["lamp"],
},
},
mtTables: mt2and3,
},
}
view = svc.sync.allMembers
for mm := range members {
mi := view.members[mm]
if mi == nil {
t.Errorf("cannot get info for syncgroup member %s", mm)
}
expInfo := expMemberInfo[mm]
if !reflect.DeepEqual(mi, expInfo) {
t.Errorf("invalid Info for syncgroup member %s: got %v instead of %v", mm, mi, expInfo)
}
}
}
// TestCollectionCompare tests the collection comparison utility.
func TestCollectionCompare(t *testing.T) {
mksgcs := func(strs []string) []wire.Id {
res := make([]wire.Id, len(strs))
for i, v := range strs {
res[i] = wire.Id{"u", v}
}
return res
}
check := func(t *testing.T, strs1, strs2 []string, want bool, msg string) {
if got := sameCollections(mksgcs(strs1), mksgcs(strs2)); got != want {
t.Errorf("sameCollections: %s: got %t instead of %t", msg, got, want)
}
}
check(t, nil, nil, true, "both nil")
check(t, []string{}, nil, true, "empty vs nil")
check(t, []string{"a", "b"}, []string{"b", "a"}, true, "different ordering")
check(t, []string{"a", "b", "c"}, []string{"b", "a"}, false, "c1 superset of c2")
check(t, []string{"a", "b"}, []string{"b", "a", "c"}, false, "c2 superset of c1")
check(t, []string{"a", "b", "c"}, []string{"b", "d", "a"}, false, "overlap")
check(t, []string{"a", "b", "c"}, []string{"x", "y"}, false, "no overlap")
check(t, []string{"a", "b"}, []string{"B", "a"}, false, "upper/lowercases")
}