commit 08a6ae5c4c9017cee7beda432b66886ccbef6626
author Adam Sadovsky <asadovsky@gmail.com> Thu Oct 08 19:38:21 2015 -0700
committer Adam Sadovsky <asadovsky@gmail.com> Thu Oct 08 19:38:21 2015 -0700
tree a9bd30688fdc53fc19265ccd5a15cedef20b3652
parent 9410285734f750016dcf1cfa6a9f524695b7da6b

TBR: reader: syncbase: s/yncGroup/yncgroup/

With this change, we establish a convention of treating
"syncgroup" as a single, common (non-proper) noun.

The main motivation for this change was consistency, for
a term that's used widely across our codebase and docs.

Arguments for "Syncgroup" over "SyncGroup" were:
- it's "Syncbase", not "SyncBase"
- we'd probably like to use "syncgroup" rather than
"sync_group" in snake-case text, e.g. in filenames like
"syncgroup_test.go"; using "SyncGroup" for camel-case
text would make these two inconsistent (Nick pointed
this out)
- avoids ambiguity about capitalization at the start of a
sentence vs. inside a sentence ("SyncGroup" vs.
"syncgroup"?)

(Note, I discussed this change with Bindu, Raja, and Nick
before making it.)

I mainly used 'find -exec perl -pi -e' to prepare this
change, plus manual inspection and tweaks. The main
painful part was updating lots of comments in the Syncbase
implementation to use "syncgroup" instead of "Syncgroup"
where that was the intended usage.

MultiPart: 9/11

Change-Id: Iec77c5e821f1315af1f6290f5fa148bd6014d867

web/browser/vanadium/syncbase/index.js

diff --git a/web/browser/vanadium/syncbase/index.js b/web/browser/vanadium/syncbase/index.js
index 200545f..4557ca2 100644
--- a/web/browser/vanadium/syncbase/index.js
+++ b/web/browser/vanadium/syncbase/index.js
@@ -418,7 +418,7 @@
   ].join('/');
   // TODO(jasoncampbell): Find docs or something about what this is and what it
   // does.
-  var info = new syncbase.nosql.SyncGroupMemberInfo({
+  var info = new syncbase.nosql.SyncgroupMemberInfo({
     syncPriority: 8
   });
 
@@ -448,14 +448,14 @@
           [ 'Debug',   { 'in': [ '...' ] } ]
         ]);
 
-    var spec = new syncbase.nosql.SyncGroupSpec({
+    var spec = new syncbase.nosql.SyncgroupSpec({
       description: 'reader syncgroup ',
       perms: permissions,
       // Prefixes are structured as {<tableName>, <keyPrefix>} where <keyPrefix>
       // matches row keys. Rows have Vanadium object names of the form
       // <syncbaseName>/reader/db/<table>/<rowKey>, so a syncgroup prefix can be
       // thought of as a vanadium namespace glob over rows.
-      prefixes: [new syncbase.nosql.SyncGroupPrefix({
+      prefixes: [new syncbase.nosql.SyncgroupPrefix({
         tableName: 'files',
         rowPrefix: 'c'
       })],
@@ -470,7 +470,7 @@
     });
 
     var ctx = context.withTimeout(ms('5s'));
-    var group = _db.syncGroup(syncname);
+    var group = _db.syncgroup(syncname);
     group.create(ctx, spec, info, oncreate);
   }
 
@@ -488,7 +488,7 @@
       }
 
       var ctx = context.withTimeout(ms('5s'));
-      var group = db.syncGroup(syncname);
+      var group = db.syncgroup(syncname);
 
       debug('joining syncgroup: %s', syncname);
       group.join(ctx, info, onjoin);