TBR ether: nick's comments from prev CL
Change-Id: I50bb2d7d2e4f9f5aa0d90f994e810ad0f7667272
diff --git a/dart/lib/echo_client.dart b/dart/lib/echo_client.dart
index a639253..d9239b7 100644
--- a/dart/lib/echo_client.dart
+++ b/dart/lib/echo_client.dart
@@ -10,16 +10,15 @@
class EchoClient {
final mojom.EchoProxy _proxy;
- final String _url;
Future close({bool immediate: false}) {
return _proxy.close(immediate: immediate);
}
- EchoClient(ConnectToServiceFn cts, this._url)
+ EchoClient(ConnectToServiceFn cts, String url)
: _proxy = new mojom.EchoProxy.unbound() {
- print('connecting to $_url');
- cts(_url, _proxy);
+ print('connecting to $url');
+ cts(url, _proxy);
print('connected');
}
diff --git a/sky_echo/lib/main.dart b/sky_echo/lib/main.dart
index 3c92aa9..0838e0c 100644
--- a/sky_echo/lib/main.dart
+++ b/sky_echo/lib/main.dart
@@ -7,7 +7,7 @@
log(String msg) {
DateTime now = new DateTime.now();
- print('${now.toString()} $msg');
+ print('$now $msg');
}
class EchoApp extends App {
@@ -15,7 +15,7 @@
EchoApp()
: _c = new EchoClient(
- embedder.connectToService, 'https://mojo.v.io/echo_server.mojo') {}
+ embedder.connectToService, 'https://mojo.v.io/echo_server.mojo');
int seq = 0;
String sendMsg = '';