TBR: oncall: add benchmark to the dashboard.
PresubmitTest: none
Change-Id: Ice651efd615fa27d73265f59d7e90f4d9a0dfe6e
diff --git a/oncall/client/browser/components/status-table/index.js b/oncall/client/browser/components/status-table/index.js
index e5c650c..c0a0de5 100644
--- a/oncall/client/browser/components/status-table/index.js
+++ b/oncall/client/browser/components/status-table/index.js
@@ -117,6 +117,28 @@
metricName: Consts.metricNames.MN_IDENTITY
}
]
+ },
+ // Benchmarks.
+ {
+ rowHeader: Consts.metricNames.MN_BENCHMARKS,
+ columns: [
+ {
+ dataKey: Consts.dataKeys.DK_SERVICE_LATENCY,
+ label: 'LATENCY',
+ metricName: Consts.metricNames.MN_BENCHMARKS,
+ threshold: 2000
+ },
+ {
+ dataKey: Consts.dataKeys.DK_SERVICE_QPS,
+ label: 'QPS',
+ metricName: Consts.metricNames.MN_BENCHMARKS
+ },
+ {
+ dataKey: Consts.dataKeys.DK_SERVICE_METADATA,
+ label: 'BUILD AGE (h)',
+ metricName: Consts.metricNames.MN_BENCHMARKS
+ }
+ ]
}
];
diff --git a/oncall/client/browser/constants.js b/oncall/client/browser/constants.js
index 04dc430..1ea8d25 100644
--- a/oncall/client/browser/constants.js
+++ b/oncall/client/browser/constants.js
@@ -19,6 +19,7 @@
/** Constants for all the metric names in the raw data. */
var metricNames = Object.freeze({
MN_BINARY_DISCHARGER: 'binary discharger',
+ MN_BENCHMARKS: 'benchmark service',
MN_IDENTITY: 'identity service',
MN_MACAROON: 'macaroon service',
MN_MOUNTTABLE: 'mounttable',
@@ -42,6 +43,7 @@
'application repository': 'APPS',
'application repository latency': 'APPS',
'applicationd': 'APPS',
+ 'benchmark service': 'BENCHMARK',
'binary discharger': 'DISCHARGER',
'binary discharger latency': 'DISCHARGER',
'binary repository': 'BINS',
diff --git a/oncall/serve.go b/oncall/serve.go
index e6f1516..57d5f29 100644
--- a/oncall/serve.go
+++ b/oncall/serve.go
@@ -528,6 +528,8 @@
switch pod.Metadata.Labels.Service {
case "auth":
retPods[monitoring.SNIdentity] = append(retPods[monitoring.SNIdentity], pod)
+ case "benchmarks":
+ retPods[monitoring.SNBenchmark] = append(retPods[monitoring.SNBenchmark], pod)
case "mounttable":
retPods[monitoring.SNMounttable] = append(retPods[monitoring.SNMounttable], pod)
case "proxy":
