syncbase: DeleteRowRange was renamed to DeleteRange
As part of https://v.io/i/672, plan was to add
Table.Delete(string key) however Dart API is missing
implementation for DeleteRange and also other Table
methods. That change therfore will come later as
part of https://v.io/i/672
MultiPart: 3/5
Change-Id: I24fd7e15e2be0de5df0e0d55c558fab5e2b884c6
diff --git a/dart/lib/src/nosql/table.dart b/dart/lib/src/nosql/table.dart
index 1e35cbc..78139ed 100644
--- a/dart/lib/src/nosql/table.dart
+++ b/dart/lib/src/nosql/table.dart
@@ -24,8 +24,17 @@
return v.exists;
}
- Future deleteRowRange(List<int> start, List<int> limit) async {
- var v = await _proxy.ptr.tableDeleteRowRange(fullName, start, limit);
+ // TODO(aghassemi):
+ // Add put(string key, value)
+ // Add get(string key)
+ // Add delete(string key)
+ // Implement deleteRange in mojo_impl.go and add tests in Dart
+ // See v.io/i/711
+
+ // TODO(aghassemi): deleteRange and scan should take a RowRange object
+ // See v.io/i/711
+ Future deleteRange(List<int> start, List<int> limit) async {
+ var v = await _proxy.ptr.tableDeleteRange(fullName, start, limit);
if (isError(v.err)) throw v.err;
}
diff --git a/mojom/syncbase.mojom b/mojom/syncbase.mojom
index 92cbc09..5ff7275 100644
--- a/mojom/syncbase.mojom
+++ b/mojom/syncbase.mojom
@@ -123,7 +123,7 @@
TableCreate(string name, Perms perms) => (Error err);
TableDestroy(string name) => (Error err);
TableExists(string name) => (Error err, bool exists);
- TableDeleteRowRange(string name, array<uint8> start, array<uint8> limit)
+ TableDeleteRange(string name, array<uint8> start, array<uint8> limit)
=> (Error err);
TableScan(
string name, array<uint8> start, array<uint8> limit, ScanStream stream)
