Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 1 | package ipc |
| 2 | |
| 3 | import ( |
Asim Shankar | b54d764 | 2014-06-05 13:08:04 -0700 | [diff] [blame] | 4 | "fmt" |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 5 | "io" |
David Why Use Two When One Will Do Presotto | b02cf90 | 2014-09-12 17:22:56 -0700 | [diff] [blame] | 6 | "math" |
David Why Use Two When One Will Do Presotto | 06c60f0 | 2014-09-11 14:52:19 -0700 | [diff] [blame] | 7 | "math/rand" |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 8 | "net" |
Suharsh Sivakumar | 67ef84a | 2015-02-13 13:04:44 -0800 | [diff] [blame] | 9 | "reflect" |
David Why Use Two When One Will Do Presotto | 06c60f0 | 2014-09-11 14:52:19 -0700 | [diff] [blame] | 10 | "strings" |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 11 | "sync" |
| 12 | "time" |
| 13 | |
Suharsh Sivakumar | af862a5 | 2015-02-04 13:50:47 -0800 | [diff] [blame] | 14 | "v.io/core/veyron/runtimes/google/ipc/stream" |
Jiri Simsa | 764efb7 | 2014-12-25 20:57:03 -0800 | [diff] [blame] | 15 | "v.io/core/veyron2/context" |
| 16 | "v.io/core/veyron2/i18n" |
| 17 | "v.io/core/veyron2/ipc" |
Jiri Simsa | 764efb7 | 2014-12-25 20:57:03 -0800 | [diff] [blame] | 18 | "v.io/core/veyron2/naming" |
| 19 | "v.io/core/veyron2/options" |
| 20 | "v.io/core/veyron2/security" |
Todd Wang | b86b352 | 2015-01-22 13:34:20 -0800 | [diff] [blame] | 21 | "v.io/core/veyron2/vdl" |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 22 | "v.io/core/veyron2/verror" |
Jiri Simsa | 764efb7 | 2014-12-25 20:57:03 -0800 | [diff] [blame] | 23 | "v.io/core/veyron2/vlog" |
Todd Wang | 3425a90 | 2015-01-21 18:43:59 -0800 | [diff] [blame] | 24 | "v.io/core/veyron2/vom" |
Jiri Simsa | 764efb7 | 2014-12-25 20:57:03 -0800 | [diff] [blame] | 25 | "v.io/core/veyron2/vtrace" |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 26 | |
Jiri Simsa | 764efb7 | 2014-12-25 20:57:03 -0800 | [diff] [blame] | 27 | "v.io/core/veyron/runtimes/google/ipc/stream/vc" |
| 28 | "v.io/core/veyron/runtimes/google/ipc/version" |
| 29 | inaming "v.io/core/veyron/runtimes/google/naming" |
| 30 | ivtrace "v.io/core/veyron/runtimes/google/vtrace" |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 31 | ) |
| 32 | |
Jiri Simsa | 764efb7 | 2014-12-25 20:57:03 -0800 | [diff] [blame] | 33 | const pkgPath = "v.io/core/veyron/runtimes/google/ipc" |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 34 | |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 35 | // TODO(cnicolaou): for local errors, automatically assign a new 'id', |
| 36 | // don't use pkgPath etc. Can then move them into being defined on each line |
| 37 | // and not here. |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 38 | var ( |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 39 | // Local errs that are used to provide details to the public ones. |
| 40 | errClientCloseAlreadyCalled = verror.Register(pkgPath+".closeAlreadyCalled", verror.NoRetry, |
| 41 | "ipc.Client.Close has already been called") |
| 42 | |
| 43 | errClientFinishAlreadyCalled = verror.Register(pkgPath+".finishAlreadyCalled", verror.NoRetry, "ipc.Call.Finish has already been called") |
| 44 | |
| 45 | errNonRootedName = verror.Register(pkgPath+".nonRootedName", verror.NoRetry, "{3} does not appear to contain an address") |
| 46 | |
| 47 | errInvalidEndpoint = verror.Register(pkgPath+".invalidEndpoint", verror.RetryRefetch, "{3} is an invalid endpoint") |
| 48 | |
| 49 | errIncompatibleEndpoint = verror.Register(pkgPath+".invalidEndpoint", verror.RetryRefetch, "{3} is an incompatible endpoint") |
| 50 | |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 51 | errNotTrusted = verror.Register(pkgPath+".notTrusted", verror.NoRetry, "name {3} not trusted using blessings {4}{:5}") |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 52 | |
| 53 | errAuthError = verror.Register(pkgPath+".authError", verror.RetryRefetch, "authentication error from server {3}{:4}") |
| 54 | |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 55 | errSystemRetry = verror.Register(pkgPath+".sysErrorRetryConnection", verror.RetryConnection, "{:3:}") |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 56 | |
Todd Wang | 34ed4c6 | 2014-11-26 15:15:52 -0800 | [diff] [blame] | 57 | errVomEncoder = verror.Register(pkgPath+".vomEncoder", verror.NoRetry, "failed to create vom encoder {:3}") |
| 58 | errVomDecoder = verror.Register(pkgPath+".vomDecoder", verror.NoRetry, "failed to create vom decoder {:3}") |
| 59 | |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 60 | errRequestEncoding = verror.Register(pkgPath+".requestEncoding", verror.NoRetry, "failed to encode request {3}{:4}") |
| 61 | |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 62 | errDischargeEncoding = verror.Register(pkgPath+".dischargeEncoding", verror.NoRetry, "failed to encode discharges {:3}") |
| 63 | |
| 64 | errBlessingEncoding = verror.Register(pkgPath+".blessingEncoding", verror.NoRetry, "failed to encode blessing {3}{:4}") |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 65 | |
| 66 | errArgEncoding = verror.Register(pkgPath+".argEncoding", verror.NoRetry, "failed to encode arg #{3}{:4:}") |
| 67 | |
Benjamin Prosnitz | 0db77a2 | 2015-01-20 14:25:15 -0800 | [diff] [blame] | 68 | errMismatchedResults = verror.Register(pkgPath+".mismatchedResults", verror.NoRetry, "got {3} results, but want {4}") |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 69 | |
| 70 | errResultDecoding = verror.Register(pkgPath+".resultDecoding", verror.NoRetry, "failed to decode result #{3}{:4}") |
| 71 | |
| 72 | errResponseDecoding = verror.Register(pkgPath+".responseDecoding", verror.NoRetry, "failed to decode response{:3}") |
| 73 | |
| 74 | errRemainingStreamResults = verror.Register(pkgPath+".remaingStreamResults", verror.NoRetry, "stream closed with remaining stream results") |
| 75 | |
| 76 | errNoBlessings = verror.Register(pkgPath+".noBlessings", verror.NoRetry, "server has not presented any blessings") |
| 77 | |
| 78 | errAuthNoPatternMatch = verror.Register(pkgPath+".authNoPatternMatch", |
Ryan Brown | 41093a9 | 2015-02-10 10:59:14 -0800 | [diff] [blame] | 79 | verror.NoRetry, "server blessings {3} do not match pattern {4}{:5}") |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 80 | |
Asim Shankar | 558ea01 | 2015-01-28 12:49:36 -0800 | [diff] [blame] | 81 | errAuthServerNotAllowed = verror.Register(pkgPath+".authServerNotAllowed", |
| 82 | verror.NoRetry, "set of allowed servers {3} not matched by server blessings {4}") |
| 83 | |
Suharsh Sivakumar | 67ef84a | 2015-02-13 13:04:44 -0800 | [diff] [blame] | 84 | errAuthServerKeyNotAllowed = verror.Register(pkgPath+".authServerKeyNotAllowed", |
| 85 | verror.NoRetry, "remote public key {3} not matched by server key {4}") |
| 86 | |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 87 | errDefaultAuthDenied = verror.Register(pkgPath+".defaultAuthDenied", verror.NoRetry, "default authorization precludes talking to server with blessings{:3}") |
| 88 | |
| 89 | errBlessingGrant = verror.Register(pkgPath+".blessingGrantFailed", verror.NoRetry, "failed to grant blessing to server with blessings {3}{:4}") |
| 90 | |
| 91 | errBlessingAdd = verror.Register(pkgPath+".blessingAddFailed", verror.NoRetry, "failed to add blessing granted to server {3}{:4}") |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 92 | ) |
| 93 | |
Ryan Brown | 2726b40 | 2014-11-04 17:13:27 -0800 | [diff] [blame] | 94 | // TODO(ribrdb): Flip this to true once everything is updated. |
| 95 | const enableSecureServerAuth = false |
| 96 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 97 | type client struct { |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 98 | streamMgr stream.Manager |
| 99 | ns naming.Namespace |
| 100 | vcOpts []stream.VCOpt // vc opts passed to dial |
| 101 | preferredProtocols []string |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 102 | |
Jungho Ahn | 25545d3 | 2015-01-26 15:14:14 -0800 | [diff] [blame] | 103 | // We cache the IP networks on the device since it is not that cheap to read |
| 104 | // network interfaces through os syscall. |
| 105 | // TODO(jhahn): Add monitoring the network interface changes. |
| 106 | ipNets []*net.IPNet |
| 107 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 108 | // We support concurrent calls to StartCall and Close, so we must protect the |
| 109 | // vcMap. Everything else is initialized upon client construction, and safe |
| 110 | // to use concurrently. |
| 111 | vcMapMu sync.Mutex |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 112 | vcMap map[vcMapKey]*vcInfo |
Andres Erbsen | b7f95f3 | 2014-07-07 12:07:56 -0700 | [diff] [blame] | 113 | |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 114 | dc vc.DischargeClient |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 115 | } |
| 116 | |
Benjamin Prosnitz | fdfbf7b | 2014-10-08 09:47:21 -0700 | [diff] [blame] | 117 | var _ ipc.Client = (*client)(nil) |
Benjamin Prosnitz | fdfbf7b | 2014-10-08 09:47:21 -0700 | [diff] [blame] | 118 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 119 | type vcInfo struct { |
| 120 | vc stream.VC |
| 121 | remoteEP naming.Endpoint |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 122 | } |
| 123 | |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 124 | type vcMapKey struct { |
| 125 | endpoint string |
| 126 | encrypted bool |
| 127 | } |
| 128 | |
Suharsh Sivakumar | d7a6519 | 2015-01-27 22:57:15 -0800 | [diff] [blame] | 129 | // PreferredProtocols instructs the Runtime implementation to select |
| 130 | // endpoints with the specified protocols and to order them in the |
| 131 | // specified order. |
| 132 | type PreferredProtocols []string |
| 133 | |
| 134 | func (PreferredProtocols) IPCClientOpt() {} |
| 135 | |
Cosmos Nicolaou | 4e02997 | 2014-06-13 14:53:08 -0700 | [diff] [blame] | 136 | func InternalNewClient(streamMgr stream.Manager, ns naming.Namespace, opts ...ipc.ClientOpt) (ipc.Client, error) { |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 137 | c := &client{ |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 138 | streamMgr: streamMgr, |
| 139 | ns: ns, |
Jungho Ahn | 25545d3 | 2015-01-26 15:14:14 -0800 | [diff] [blame] | 140 | ipNets: ipNetworks(), |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 141 | vcMap: make(map[vcMapKey]*vcInfo), |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 142 | } |
Suharsh Sivakumar | 1b6683e | 2014-12-30 13:00:38 -0800 | [diff] [blame] | 143 | c.dc = InternalNewDischargeClient(nil, c) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 144 | for _, opt := range opts { |
| 145 | // Collect all client opts that are also vc opts. |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 146 | switch v := opt.(type) { |
| 147 | case stream.VCOpt: |
| 148 | c.vcOpts = append(c.vcOpts, v) |
Suharsh Sivakumar | d7a6519 | 2015-01-27 22:57:15 -0800 | [diff] [blame] | 149 | case PreferredProtocols: |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 150 | c.preferredProtocols = v |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 151 | } |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 152 | } |
Suharsh Sivakumar | 1b6683e | 2014-12-30 13:00:38 -0800 | [diff] [blame] | 153 | c.vcOpts = append(c.vcOpts, c.dc) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 154 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 155 | return c, nil |
| 156 | } |
| 157 | |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 158 | func vcEncrypted(vcOpts []stream.VCOpt) bool { |
| 159 | encrypted := true |
| 160 | for _, o := range vcOpts { |
| 161 | switch o { |
| 162 | case options.VCSecurityNone: |
| 163 | encrypted = false |
| 164 | case options.VCSecurityConfidential: |
| 165 | encrypted = true |
| 166 | } |
| 167 | } |
| 168 | return encrypted |
| 169 | } |
| 170 | |
Mike Burrows | dc6b360 | 2015-02-05 15:52:12 -0800 | [diff] [blame] | 171 | func (c *client) createFlow(ctx *context.T, ep naming.Endpoint, vcOpts []stream.VCOpt) (stream.Flow, error) { |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 172 | c.vcMapMu.Lock() |
| 173 | defer c.vcMapMu.Unlock() |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 174 | if c.vcMap == nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 175 | return nil, verror.New(errClientCloseAlreadyCalled, ctx) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 176 | } |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 177 | vcKey := vcMapKey{ep.String(), vcEncrypted(vcOpts)} |
| 178 | if vcinfo := c.vcMap[vcKey]; vcinfo != nil { |
Bogdan Caprita | 783f779 | 2014-05-15 09:29:17 -0700 | [diff] [blame] | 179 | if flow, err := vcinfo.vc.Connect(); err == nil { |
| 180 | return flow, nil |
| 181 | } |
| 182 | // If the vc fails to establish a new flow, we assume it's |
| 183 | // broken, remove it from the map, and proceed to establishing |
| 184 | // a new vc. |
| 185 | // TODO(caprita): Should we distinguish errors due to vc being |
| 186 | // closed from other errors? If not, should we call vc.Close() |
| 187 | // before removing the vc from the map? |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 188 | delete(c.vcMap, vcKey) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 189 | } |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 190 | sm := c.streamMgr |
Robin Thellend | ee43964 | 2014-10-20 14:39:17 -0700 | [diff] [blame] | 191 | c.vcMapMu.Unlock() |
Asim Shankar | 7049475 | 2015-01-23 16:10:23 -0800 | [diff] [blame] | 192 | // Include the context when Dial-ing. This is currently done via an |
| 193 | // option, and for thread-safety reasons - cannot append directly to |
| 194 | // vcOpts. |
| 195 | // TODO(ashankar,mattr): Revisit the API in ipc/stream and explicitly |
| 196 | // provide a context to Dial and other relevant operations. |
| 197 | cpy := make([]stream.VCOpt, len(vcOpts)+1) |
| 198 | cpy[copy(cpy, vcOpts)] = vc.DialContext{ctx} |
| 199 | vcOpts = cpy |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 200 | vc, err := sm.Dial(ep, vcOpts...) |
Robin Thellend | ee43964 | 2014-10-20 14:39:17 -0700 | [diff] [blame] | 201 | c.vcMapMu.Lock() |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 202 | if err != nil { |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 203 | if strings.Contains(err.Error(), "authentication failed") { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 204 | return nil, verror.New(errAuthError, ctx, ep, err) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 205 | } else { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 206 | return nil, verror.New(errSystemRetry, ctx, err) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 207 | } |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 208 | } |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 209 | if c.vcMap == nil { |
| 210 | sm.ShutdownEndpoint(ep) |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 211 | return nil, verror.New(errClientCloseAlreadyCalled, ctx) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 212 | } |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 213 | if othervc, exists := c.vcMap[vcKey]; exists { |
Robin Thellend | ee43964 | 2014-10-20 14:39:17 -0700 | [diff] [blame] | 214 | vc = othervc.vc |
| 215 | // TODO(ashankar,toddw): Figure out how to close up the VC that |
| 216 | // is discarded. vc.Close? |
| 217 | } else { |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 218 | c.vcMap[vcKey] = &vcInfo{vc: vc, remoteEP: ep} |
Robin Thellend | ee43964 | 2014-10-20 14:39:17 -0700 | [diff] [blame] | 219 | } |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 220 | flow, err := vc.Connect() |
| 221 | if err != nil { |
| 222 | |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 223 | return nil, verror.New(errAuthError, ctx, ep, err) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 224 | } |
| 225 | return flow, nil |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 226 | } |
| 227 | |
David Why Use Two When One Will Do Presotto | b02cf90 | 2014-09-12 17:22:56 -0700 | [diff] [blame] | 228 | // A randomized exponential backoff. The randomness deters error convoys from forming. |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 229 | // TODO(cnicolaou): rationalize this and the backoff in ipc.Server. Note |
| 230 | // that rand is not thread safe and may crash. |
David Why Use Two When One Will Do Presotto | b02cf90 | 2014-09-12 17:22:56 -0700 | [diff] [blame] | 231 | func backoff(n int, deadline time.Time) bool { |
| 232 | b := time.Duration(math.Pow(1.5+(rand.Float64()/2.0), float64(n)) * float64(time.Second)) |
| 233 | if b > maxBackoff { |
| 234 | b = maxBackoff |
| 235 | } |
| 236 | r := deadline.Sub(time.Now()) |
| 237 | if b > r { |
| 238 | // We need to leave a little time for the call to start or |
| 239 | // we'll just timeout in startCall before we actually do |
| 240 | // anything. If we just have a millisecond left, give up. |
| 241 | if r <= time.Millisecond { |
| 242 | return false |
| 243 | } |
| 244 | b = r - time.Millisecond |
| 245 | } |
| 246 | time.Sleep(b) |
| 247 | return true |
| 248 | } |
| 249 | |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 250 | func (c *client) StartCall(ctx *context.T, name, method string, args []interface{}, opts ...ipc.CallOpt) (ipc.Call, error) { |
| 251 | defer vlog.LogCall()() |
| 252 | return c.startCall(ctx, name, method, args, opts) |
| 253 | } |
| 254 | |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 255 | func getRetryTimeoutOpt(opts []ipc.CallOpt) (time.Duration, bool) { |
| 256 | for _, o := range opts { |
Asim Shankar | cc04421 | 2014-10-15 23:25:26 -0700 | [diff] [blame] | 257 | if r, ok := o.(options.RetryTimeout); ok { |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 258 | return time.Duration(r), true |
| 259 | } |
| 260 | } |
| 261 | return 0, false |
| 262 | } |
| 263 | |
Matt Rosencrantz | 321a51d | 2014-10-30 10:37:56 -0700 | [diff] [blame] | 264 | func getNoResolveOpt(opts []ipc.CallOpt) bool { |
| 265 | for _, o := range opts { |
Suharsh Sivakumar | b59a96d | 2015-01-09 16:39:54 -0800 | [diff] [blame] | 266 | if _, ok := o.(options.NoResolve); ok { |
| 267 | return true |
Matt Rosencrantz | 321a51d | 2014-10-30 10:37:56 -0700 | [diff] [blame] | 268 | } |
| 269 | } |
| 270 | return false |
| 271 | } |
| 272 | |
Suharsh Sivakumar | 1131687 | 2014-11-25 15:57:00 -0800 | [diff] [blame] | 273 | func shouldNotFetchDischarges(opts []ipc.CallOpt) bool { |
| 274 | for _, o := range opts { |
| 275 | if _, ok := o.(vc.NoDischarges); ok { |
| 276 | return true |
| 277 | } |
| 278 | } |
| 279 | return false |
| 280 | } |
| 281 | |
Suharsh Sivakumar | 90da4c2 | 2015-02-12 15:45:56 -0800 | [diff] [blame] | 282 | func getNoRetryOpt(opts []ipc.CallOpt) bool { |
| 283 | for _, o := range opts { |
| 284 | if _, ok := o.(options.NoRetry); ok { |
| 285 | return true |
| 286 | } |
| 287 | } |
| 288 | return false |
| 289 | } |
| 290 | |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 291 | func getVCOpts(opts []ipc.CallOpt) (vcOpts []stream.VCOpt) { |
| 292 | for _, o := range opts { |
| 293 | if v, ok := o.(stream.VCOpt); ok { |
| 294 | vcOpts = append(vcOpts, v) |
| 295 | } |
| 296 | } |
| 297 | return |
| 298 | } |
| 299 | |
| 300 | func getResolveOpts(opts []ipc.CallOpt) (resolveOpts []naming.ResolveOpt) { |
| 301 | for _, o := range opts { |
| 302 | if r, ok := o.(naming.ResolveOpt); ok { |
| 303 | resolveOpts = append(resolveOpts, r) |
| 304 | } |
| 305 | } |
| 306 | return |
| 307 | } |
| 308 | |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 309 | func mkDischargeImpetus(serverBlessings []string, method string, args []interface{}) security.DischargeImpetus { |
| 310 | var impetus security.DischargeImpetus |
| 311 | if len(serverBlessings) > 0 { |
| 312 | impetus.Server = make([]security.BlessingPattern, len(serverBlessings)) |
| 313 | for i, b := range serverBlessings { |
| 314 | impetus.Server[i] = security.BlessingPattern(b) |
| 315 | } |
| 316 | } |
| 317 | impetus.Method = method |
| 318 | if len(args) > 0 { |
Todd Wang | b86b352 | 2015-01-22 13:34:20 -0800 | [diff] [blame] | 319 | impetus.Arguments = make([]vdl.AnyRep, len(args)) |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 320 | for i, a := range args { |
Todd Wang | b86b352 | 2015-01-22 13:34:20 -0800 | [diff] [blame] | 321 | impetus.Arguments[i] = vdl.AnyRep(a) |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 322 | } |
| 323 | } |
| 324 | return impetus |
| 325 | } |
| 326 | |
Mike Burrows | dc6b360 | 2015-02-05 15:52:12 -0800 | [diff] [blame] | 327 | // startCall ensures StartCall always returns verror.Standard. |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 328 | func (c *client) startCall(ctx *context.T, name, method string, args []interface{}, opts []ipc.CallOpt) (ipc.Call, error) { |
Matt Rosencrantz | 4f8ac60 | 2014-12-29 14:42:48 -0800 | [diff] [blame] | 329 | if !ctx.Initialized() { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 330 | return nil, verror.ExplicitNew(verror.ErrBadArg, i18n.NoLangID, "ipc.Client", "StartCall") |
Matt Rosencrantz | 321a51d | 2014-10-30 10:37:56 -0700 | [diff] [blame] | 331 | } |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 332 | |
Matt Rosencrantz | 5f98d94 | 2015-01-08 13:48:30 -0800 | [diff] [blame] | 333 | ctx, span := vtrace.SetNewSpan(ctx, fmt.Sprintf("<client>%q.%s", name, method)) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 334 | ctx = verror.ContextWithComponentName(ctx, "ipc.Client") |
Matt Rosencrantz | 321a51d | 2014-10-30 10:37:56 -0700 | [diff] [blame] | 335 | |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 336 | // Context specified deadline. |
David Why Use Two When One Will Do Presotto | 06c60f0 | 2014-09-11 14:52:19 -0700 | [diff] [blame] | 337 | deadline, hasDeadline := ctx.Deadline() |
| 338 | if !hasDeadline { |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 339 | // Default deadline. |
David Why Use Two When One Will Do Presotto | 06c60f0 | 2014-09-11 14:52:19 -0700 | [diff] [blame] | 340 | deadline = time.Now().Add(defaultCallTimeout) |
| 341 | } |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 342 | if r, ok := getRetryTimeoutOpt(opts); ok { |
| 343 | // Caller specified deadline. |
| 344 | deadline = time.Now().Add(time.Duration(r)) |
David Why Use Two When One Will Do Presotto | b02cf90 | 2014-09-12 17:22:56 -0700 | [diff] [blame] | 345 | } |
Matt Rosencrantz | cc922c1 | 2014-11-28 20:28:59 -0800 | [diff] [blame] | 346 | |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 347 | var lastErr error |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 348 | for retries := 0; ; retries++ { |
David Why Use Two When One Will Do Presotto | b02cf90 | 2014-09-12 17:22:56 -0700 | [diff] [blame] | 349 | if retries != 0 { |
| 350 | if !backoff(retries, deadline) { |
| 351 | break |
| 352 | } |
| 353 | } |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 354 | call, action, err := c.tryCall(ctx, name, method, args, opts) |
David Why Use Two When One Will Do Presotto | 06c60f0 | 2014-09-11 14:52:19 -0700 | [diff] [blame] | 355 | if err == nil { |
| 356 | return call, nil |
| 357 | } |
| 358 | lastErr = err |
Matt Rosencrantz | cc922c1 | 2014-11-28 20:28:59 -0800 | [diff] [blame] | 359 | shouldRetry := true |
| 360 | switch { |
Suharsh Sivakumar | 90da4c2 | 2015-02-12 15:45:56 -0800 | [diff] [blame] | 361 | case getNoRetryOpt(opts): |
| 362 | shouldRetry = false |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 363 | case action != verror.RetryConnection && action != verror.RetryRefetch: |
Matt Rosencrantz | cc922c1 | 2014-11-28 20:28:59 -0800 | [diff] [blame] | 364 | shouldRetry = false |
| 365 | case time.Now().After(deadline): |
| 366 | shouldRetry = false |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 367 | case action == verror.RetryRefetch && getNoResolveOpt(opts): |
Matt Rosencrantz | cc922c1 | 2014-11-28 20:28:59 -0800 | [diff] [blame] | 368 | // If we're skipping resolution and there are no servers for |
| 369 | // this call retrying is not going to help, we can't come up |
| 370 | // with new servers if there is no resolution. |
| 371 | shouldRetry = false |
| 372 | } |
Matt Rosencrantz | cc922c1 | 2014-11-28 20:28:59 -0800 | [diff] [blame] | 373 | if !shouldRetry { |
Matt Rosencrantz | abacd43 | 2014-11-24 10:44:31 -0800 | [diff] [blame] | 374 | span.Annotatef("Cannot retry after error: %s", err) |
David Why Use Two When One Will Do Presotto | 06c60f0 | 2014-09-11 14:52:19 -0700 | [diff] [blame] | 375 | break |
| 376 | } |
Matt Rosencrantz | abacd43 | 2014-11-24 10:44:31 -0800 | [diff] [blame] | 377 | span.Annotatef("Retrying due to error: %s", err) |
David Why Use Two When One Will Do Presotto | 06c60f0 | 2014-09-11 14:52:19 -0700 | [diff] [blame] | 378 | } |
| 379 | return nil, lastErr |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 380 | } |
| 381 | |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 382 | type serverStatus struct { |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 383 | index int |
| 384 | suffix string |
| 385 | flow stream.Flow |
Mike Burrows | dc6b360 | 2015-02-05 15:52:12 -0800 | [diff] [blame] | 386 | err error |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 387 | } |
| 388 | |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 389 | // tryCreateFlow attempts to establish a Flow to "server" (which must be a |
| 390 | // rooted name), over which a method invocation request could be sent. |
Cosmos Nicolaou | 00a0f80 | 2014-11-16 22:44:55 -0800 | [diff] [blame] | 391 | // TODO(cnicolaou): implement real, configurable load balancing. |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 392 | func (c *client) tryCreateFlow(ctx *context.T, index int, server string, ch chan<- *serverStatus, vcOpts []stream.VCOpt) { |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 393 | status := &serverStatus{index: index} |
Asim Shankar | f4864f4 | 2014-11-25 18:53:05 -0800 | [diff] [blame] | 394 | var span vtrace.Span |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 395 | ctx, span = vtrace.SetNewSpan(ctx, "<client>tryCreateFlow") |
Asim Shankar | f4864f4 | 2014-11-25 18:53:05 -0800 | [diff] [blame] | 396 | span.Annotatef("address:%v", server) |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 397 | defer func() { |
| 398 | ch <- status |
| 399 | span.Finish() |
| 400 | }() |
| 401 | address, suffix := naming.SplitAddressName(server) |
| 402 | if len(address) == 0 { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 403 | status.err = verror.New(errNonRootedName, ctx, server) |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 404 | return |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 405 | } |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 406 | ep, err := inaming.NewEndpoint(address) |
| 407 | if err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 408 | status.err = verror.New(errInvalidEndpoint, ctx, address) |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 409 | return |
| 410 | } |
| 411 | if err = version.CheckCompatibility(ep); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 412 | status.err = verror.New(errIncompatibleEndpoint, ctx, ep) |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 413 | return |
| 414 | } |
| 415 | if status.flow, status.err = c.createFlow(ctx, ep, vcOpts); status.err != nil { |
| 416 | vlog.VI(2).Infof("ipc: connect to %v: %v", server, status.err) |
| 417 | return |
| 418 | } |
| 419 | status.suffix = suffix |
| 420 | return |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 421 | } |
| 422 | |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 423 | // tryCall makes a single attempt at a call. It may connect to multiple servers |
| 424 | // (all that serve "name"), but will invoke the method on at most one of them |
| 425 | // (the server running on the most preferred protcol and network amongst all |
| 426 | // the servers that were successfully connected to and authorized). |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 427 | func (c *client) tryCall(ctx *context.T, name, method string, args []interface{}, opts []ipc.CallOpt) (ipc.Call, verror.ActionCode, error) { |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 428 | var resolved *naming.MountEntry |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 429 | var err error |
| 430 | if resolved, err = c.ns.Resolve(ctx, name, getResolveOpts(opts)...); err != nil { |
David Why Use Two When One Will Do Presotto | 8de8585 | 2015-01-21 11:05:09 -0800 | [diff] [blame] | 431 | vlog.Errorf("Resolve: %v", err) |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 432 | // We always return NoServers as the error so that the caller knows |
| 433 | // that's ok to retry the operation since the name may be registered |
| 434 | // in the near future. |
Ryan Brown | 6153c6c | 2014-12-11 13:10:09 -0800 | [diff] [blame] | 435 | if verror.Is(err, naming.ErrNoSuchName.ID) { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 436 | return nil, verror.RetryRefetch, verror.New(verror.ErrNoServers, ctx, name) |
Ryan Brown | 6153c6c | 2014-12-11 13:10:09 -0800 | [diff] [blame] | 437 | } |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 438 | return nil, verror.NoRetry, verror.New(verror.ErrNoServers, ctx, name, err) |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 439 | } else { |
Ryan Brown | 6153c6c | 2014-12-11 13:10:09 -0800 | [diff] [blame] | 440 | if len(resolved.Servers) == 0 { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 441 | return nil, verror.RetryRefetch, verror.New(verror.ErrNoServers, ctx, name) |
Suharsh Sivakumar | 65e44c2 | 2014-12-10 17:15:19 -0800 | [diff] [blame] | 442 | } |
Ryan Brown | 6153c6c | 2014-12-11 13:10:09 -0800 | [diff] [blame] | 443 | // An empty set of protocols means all protocols... |
Jungho Ahn | 25545d3 | 2015-01-26 15:14:14 -0800 | [diff] [blame] | 444 | if resolved.Servers, err = filterAndOrderServers(resolved.Servers, c.preferredProtocols, c.ipNets); err != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 445 | return nil, verror.RetryRefetch, verror.New(verror.ErrNoServers, ctx, name, err) |
David Why Use Two When One Will Do Presotto | 3da1c79 | 2014-10-03 11:15:53 -0700 | [diff] [blame] | 446 | } |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 447 | } |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 448 | |
Asim Shankar | b547ea9 | 2015-02-17 18:49:45 -0800 | [diff] [blame^] | 449 | // servers is now ordered by the priority heurestic implemented in |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 450 | // filterAndOrderServers. |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 451 | // |
| 452 | // Try to connect to all servers in parallel. Provide sufficient |
| 453 | // buffering for all of the connections to finish instantaneously. This |
| 454 | // is important because we want to process the responses in priority |
| 455 | // order; that order is indicated by the order of entries in servers. |
| 456 | // So, if two respones come in at the same 'instant', we prefer the |
| 457 | // first in the resolved.Servers) |
| 458 | attempts := len(resolved.Servers) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 459 | responses := make([]*serverStatus, attempts) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 460 | ch := make(chan *serverStatus, attempts) |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 461 | vcOpts := append(getVCOpts(opts), c.vcOpts...) |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 462 | for i, server := range resolved.Names() { |
| 463 | go c.tryCreateFlow(ctx, i, server, ch, vcOpts) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 464 | } |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 465 | |
| 466 | delay := time.Duration(ipc.NoTimeout) |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 467 | if dl, ok := ctx.Deadline(); ok { |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 468 | delay = dl.Sub(time.Now()) |
| 469 | } |
| 470 | timeoutChan := time.After(delay) |
| 471 | |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 472 | for { |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 473 | // Block for at least one new response from the server, or the timeout. |
| 474 | select { |
| 475 | case r := <-ch: |
| 476 | responses[r.index] = r |
| 477 | // Read as many more responses as we can without blocking. |
| 478 | LoopNonBlocking: |
| 479 | for { |
| 480 | select { |
| 481 | default: |
| 482 | break LoopNonBlocking |
| 483 | case r := <-ch: |
| 484 | responses[r.index] = r |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 485 | } |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 486 | } |
| 487 | case <-timeoutChan: |
| 488 | vlog.VI(2).Infof("ipc: timeout on connection to server %v ", name) |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 489 | _, _, err := c.failedTryCall(ctx, name, method, responses, ch) |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 490 | if !verror.Is(err, verror.ErrTimeout.ID) { |
| 491 | return nil, verror.NoRetry, verror.New(verror.ErrTimeout, ctx, err) |
Cosmos Nicolaou | 38209d4 | 2014-12-09 16:50:38 -0800 | [diff] [blame] | 492 | } |
| 493 | return nil, verror.NoRetry, err |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 494 | } |
| 495 | |
| 496 | // Process new responses, in priority order. |
| 497 | numResponses := 0 |
Suharsh Sivakumar | ae774a5 | 2015-01-09 14:26:32 -0800 | [diff] [blame] | 498 | noDischarges := shouldNotFetchDischarges(opts) |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 499 | for _, r := range responses { |
| 500 | if r != nil { |
| 501 | numResponses++ |
| 502 | } |
| 503 | if r == nil || r.flow == nil { |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 504 | continue |
| 505 | } |
Matt Rosencrantz | fa3082c | 2015-01-22 21:39:04 -0800 | [diff] [blame] | 506 | |
Matt Rosencrantz | 1094d06 | 2015-01-30 06:43:12 -0800 | [diff] [blame] | 507 | doneChan := ctx.Done() |
Matt Rosencrantz | fa3082c | 2015-01-22 21:39:04 -0800 | [diff] [blame] | 508 | r.flow.SetDeadline(doneChan) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 509 | |
| 510 | var ( |
| 511 | serverB []string |
| 512 | grantedB security.Blessings |
| 513 | ) |
| 514 | |
| 515 | // LocalPrincipal is nil means that the client wanted to avoid |
| 516 | // authentication, and thus wanted to skip authorization as well. |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 517 | if r.flow.LocalPrincipal() != nil { |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 518 | // Validate caveats on the server's identity for the context associated with this call. |
| 519 | var err error |
Asim Shankar | b547ea9 | 2015-02-17 18:49:45 -0800 | [diff] [blame^] | 520 | patterns := resolved.Servers[r.index].BlessingPatterns |
| 521 | if serverB, grantedB, err = c.authorizeServer(ctx, r.flow, name, method, patterns, opts); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 522 | r.err = verror.New(errNotTrusted, ctx, name, r.flow.RemoteBlessings(), err) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 523 | vlog.VI(2).Infof("ipc: err: %s", r.err) |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 524 | r.flow.Close() |
| 525 | r.flow = nil |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 526 | continue |
| 527 | } |
| 528 | } |
| 529 | |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 530 | // This is the 'point of no return'; once the RPC is started (fc.start |
| 531 | // below) we can't be sure if it makes it to the server or not so, this |
| 532 | // code will never call fc.start more than once to ensure that we provide |
| 533 | // 'at-most-once' rpc semantics at this level. Retrying the network |
| 534 | // connections (i.e. creating flows) is fine since we can cleanup that |
| 535 | // state if we abort a call (i.e. close the flow). |
| 536 | // |
| 537 | // We must ensure that all flows other than r.flow are closed. |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 538 | // |
| 539 | // TODO(cnicolaou): all errors below are marked as NoRetry |
| 540 | // because we want to provide at-most-once rpc semantics so |
| 541 | // we only ever attempt an RPC once. In the future, we'll cache |
| 542 | // responses on the server and then we can retry in-process |
| 543 | // RPCs. |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 544 | go cleanupTryCall(r, responses, ch) |
Todd Wang | 34ed4c6 | 2014-11-26 15:15:52 -0800 | [diff] [blame] | 545 | fc, err := newFlowClient(ctx, serverB, r.flow, c.dc) |
| 546 | if err != nil { |
Mike Burrows | dc6b360 | 2015-02-05 15:52:12 -0800 | [diff] [blame] | 547 | return nil, verror.NoRetry, err.(error) |
Todd Wang | 34ed4c6 | 2014-11-26 15:15:52 -0800 | [diff] [blame] | 548 | } |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 549 | |
Matt Rosencrantz | fa3082c | 2015-01-22 21:39:04 -0800 | [diff] [blame] | 550 | if doneChan != nil { |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 551 | go func() { |
| 552 | select { |
Matt Rosencrantz | fa3082c | 2015-01-22 21:39:04 -0800 | [diff] [blame] | 553 | case <-doneChan: |
Matt Rosencrantz | 5f98d94 | 2015-01-08 13:48:30 -0800 | [diff] [blame] | 554 | vtrace.GetSpan(fc.ctx).Annotate("Cancelled") |
Matt Rosencrantz | 9346b41 | 2014-12-18 15:59:19 -0800 | [diff] [blame] | 555 | fc.flow.Cancel() |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 556 | case <-fc.flow.Closed(): |
| 557 | } |
| 558 | }() |
| 559 | } |
| 560 | |
| 561 | timeout := time.Duration(ipc.NoTimeout) |
| 562 | if deadline, hasDeadline := ctx.Deadline(); hasDeadline { |
| 563 | timeout = deadline.Sub(time.Now()) |
| 564 | } |
Suharsh Sivakumar | 1131687 | 2014-11-25 15:57:00 -0800 | [diff] [blame] | 565 | if noDischarges { |
| 566 | fc.dc = nil |
| 567 | } |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 568 | if verr := fc.start(r.suffix, method, args, timeout, grantedB); verr != nil { |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 569 | return nil, verror.NoRetry, verr |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 570 | } |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 571 | return fc, verror.NoRetry, nil |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 572 | } |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 573 | if numResponses == len(responses) { |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 574 | return c.failedTryCall(ctx, name, method, responses, ch) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 575 | } |
| 576 | } |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 577 | } |
| 578 | |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 579 | // cleanupTryCall ensures we've waited for every response from the tryCreateFlow |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 580 | // goroutines, and have closed the flow from each one except skip. This is a |
| 581 | // blocking function; it should be called in its own goroutine. |
| 582 | func cleanupTryCall(skip *serverStatus, responses []*serverStatus, ch chan *serverStatus) { |
| 583 | numPending := 0 |
| 584 | for _, r := range responses { |
| 585 | switch { |
| 586 | case r == nil: |
| 587 | // The response hasn't arrived yet. |
| 588 | numPending++ |
| 589 | case r == skip || r.flow == nil: |
| 590 | // Either we should skip this flow, or we've closed the flow for this |
| 591 | // response already; nothing more to do. |
| 592 | default: |
| 593 | // We received the response, but haven't closed the flow yet. |
| 594 | r.flow.Close() |
| 595 | } |
| 596 | } |
| 597 | // Now we just need to wait for the pending responses and close their flows. |
| 598 | for i := 0; i < numPending; i++ { |
| 599 | if r := <-ch; r.flow != nil { |
| 600 | r.flow.Close() |
| 601 | } |
| 602 | } |
| 603 | } |
| 604 | |
| 605 | // failedTryCall performs asynchronous cleanup for tryCall, and returns an |
| 606 | // appropriate error from the responses we've already received. All parallel |
| 607 | // calls in tryCall failed or we timed out if we get here. |
Mike Burrows | dc6b360 | 2015-02-05 15:52:12 -0800 | [diff] [blame] | 608 | func (c *client) failedTryCall(ctx *context.T, name, method string, responses []*serverStatus, ch chan *serverStatus) (ipc.Call, verror.ActionCode, error) { |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 609 | go cleanupTryCall(nil, responses, ch) |
Cosmos Nicolaou | 4e8da64 | 2014-11-13 08:32:05 -0800 | [diff] [blame] | 610 | c.ns.FlushCacheEntry(name) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 611 | noconn, untrusted := []string{}, []string{} |
Asim Shankar | aae3180 | 2015-01-22 11:59:42 -0800 | [diff] [blame] | 612 | for _, r := range responses { |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 613 | if r != nil && r.err != nil { |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 614 | switch { |
| 615 | case verror.Is(r.err, errNotTrusted.ID) || verror.Is(r.err, errAuthError.ID): |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 616 | untrusted = append(untrusted, "("+r.err.Error()+") ") |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 617 | default: |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 618 | noconn = append(noconn, "("+r.err.Error()+") ") |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 619 | } |
Todd Wang | ef05c06 | 2014-11-15 09:51:43 -0800 | [diff] [blame] | 620 | } |
| 621 | } |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 622 | // TODO(cnicolaou): we get system errors for things like dialing using |
| 623 | // the 'ws' protocol which can never succeed even if we retry the connection, |
| 624 | // hence we return RetryRefetch in all cases below. In the future, we'll |
| 625 | // pick out this error and then we can retry the connection also. This also |
| 626 | // plays into the 'at-most-once' rpc semantics change that's needed in order |
| 627 | // to retry an in-flight RPC. |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 628 | switch { |
| 629 | case len(untrusted) > 0 && len(noconn) > 0: |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 630 | return nil, verror.RetryRefetch, verror.New(verror.ErrNoServersAndAuth, ctx, append(noconn, untrusted...)) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 631 | case len(noconn) > 0: |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 632 | return nil, verror.RetryRefetch, verror.New(verror.ErrNoServers, ctx, noconn) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 633 | case len(untrusted) > 0: |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 634 | return nil, verror.NoRetry, verror.New(verror.ErrNotTrusted, ctx, untrusted) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 635 | default: |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 636 | return nil, verror.RetryRefetch, verror.New(verror.ErrTimeout, ctx) |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 637 | } |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 638 | } |
| 639 | |
Asim Shankar | 8f05c22 | 2014-10-06 22:08:19 -0700 | [diff] [blame] | 640 | // authorizeServer validates that the server (remote end of flow) has the credentials to serve |
| 641 | // the RPC name.method for the client (local end of the flow). It returns the blessings at the |
| 642 | // server that are authorized for this purpose and any blessings that are to be granted to |
| 643 | // the server (via ipc.Granter implementations in opts.) |
Asim Shankar | b547ea9 | 2015-02-17 18:49:45 -0800 | [diff] [blame^] | 644 | func (c *client) authorizeServer(ctx *context.T, flow stream.Flow, name, method string, serverPatterns []string, opts []ipc.CallOpt) (serverBlessings []string, grantedBlessings security.Blessings, err error) { |
Asim Shankar | 220a015 | 2014-10-30 21:21:09 -0700 | [diff] [blame] | 645 | if flow.RemoteBlessings() == nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 646 | return nil, nil, verror.New(errNoBlessings, ctx) |
Asim Shankar | b54d764 | 2014-06-05 13:08:04 -0700 | [diff] [blame] | 647 | } |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 648 | ctxt := security.NewContext(&security.ContextParams{ |
| 649 | LocalPrincipal: flow.LocalPrincipal(), |
| 650 | LocalBlessings: flow.LocalBlessings(), |
| 651 | RemoteBlessings: flow.RemoteBlessings(), |
| 652 | LocalEndpoint: flow.LocalEndpoint(), |
| 653 | RemoteEndpoint: flow.RemoteEndpoint(), |
| 654 | RemoteDischarges: flow.RemoteDischarges(), |
| 655 | Method: method, |
Todd Wang | 9a7f516 | 2014-11-13 13:24:33 -0800 | [diff] [blame] | 656 | Suffix: name}) |
Asim Shankar | b547ea9 | 2015-02-17 18:49:45 -0800 | [diff] [blame^] | 657 | var rejectedBlessings []security.RejectedBlessing |
| 658 | serverBlessings, rejectedBlessings = flow.RemoteBlessings().ForContext(ctxt) |
| 659 | var ignorePatterns bool |
Asim Shankar | b54d764 | 2014-06-05 13:08:04 -0700 | [diff] [blame] | 660 | for _, o := range opts { |
| 661 | switch v := o.(type) { |
Suharsh Sivakumar | 67ef84a | 2015-02-13 13:04:44 -0800 | [diff] [blame] | 662 | case options.ServerPublicKey: |
Suharsh Sivakumar | a8633b0 | 2015-02-14 17:08:07 -0800 | [diff] [blame] | 663 | if remoteKey, key := flow.RemoteBlessings().PublicKey(), v.PublicKey; !reflect.DeepEqual(remoteKey, key) { |
| 664 | return nil, nil, verror.New(errAuthServerKeyNotAllowed, ctx, remoteKey, key) |
Suharsh Sivakumar | 67ef84a | 2015-02-13 13:04:44 -0800 | [diff] [blame] | 665 | } |
Asim Shankar | 558ea01 | 2015-01-28 12:49:36 -0800 | [diff] [blame] | 666 | case options.AllowedServersPolicy: |
| 667 | allowed := false |
| 668 | for _, p := range v { |
| 669 | if p.MatchedBy(serverBlessings...) { |
| 670 | allowed = true |
| 671 | break |
| 672 | } |
| 673 | } |
| 674 | if !allowed { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 675 | return nil, nil, verror.New(errAuthServerNotAllowed, ctx, v, serverBlessings) |
Asim Shankar | 558ea01 | 2015-01-28 12:49:36 -0800 | [diff] [blame] | 676 | } |
Asim Shankar | b547ea9 | 2015-02-17 18:49:45 -0800 | [diff] [blame^] | 677 | case options.SkipResolveAuthorization: |
| 678 | ignorePatterns = true |
Asim Shankar | b54d764 | 2014-06-05 13:08:04 -0700 | [diff] [blame] | 679 | case ipc.Granter: |
Asim Shankar | 8f05c22 | 2014-10-06 22:08:19 -0700 | [diff] [blame] | 680 | if b, err := v.Grant(flow.RemoteBlessings()); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 681 | return nil, nil, verror.New(errBlessingGrant, ctx, serverBlessings, err) |
Asim Shankar | 8f05c22 | 2014-10-06 22:08:19 -0700 | [diff] [blame] | 682 | } else if grantedBlessings, err = security.UnionOfBlessings(grantedBlessings, b); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 683 | return nil, nil, verror.New(errBlessingAdd, ctx, serverBlessings, err) |
Asim Shankar | 8f05c22 | 2014-10-06 22:08:19 -0700 | [diff] [blame] | 684 | } |
Asim Shankar | b54d764 | 2014-06-05 13:08:04 -0700 | [diff] [blame] | 685 | } |
| 686 | } |
Asim Shankar | b547ea9 | 2015-02-17 18:49:45 -0800 | [diff] [blame^] | 687 | if len(serverPatterns) > 0 && !ignorePatterns { |
| 688 | matched := false |
| 689 | for _, p := range serverPatterns { |
| 690 | if security.BlessingPattern(p).MatchedBy(serverBlessings...) { |
| 691 | matched = true |
| 692 | break |
| 693 | } |
| 694 | } |
| 695 | if !matched { |
| 696 | return nil, nil, verror.New(errAuthNoPatternMatch, ctx, serverBlessings, serverPatterns, rejectedBlessings) |
| 697 | } |
| 698 | } else if enableSecureServerAuth && !ignorePatterns { |
| 699 | if err := (defaultAuthorizer{}).Authorize(ctxt); err != nil { |
| 700 | return nil, nil, verror.New(errDefaultAuthDenied, ctx, serverBlessings) |
| 701 | } |
| 702 | } |
Asim Shankar | 8f05c22 | 2014-10-06 22:08:19 -0700 | [diff] [blame] | 703 | return serverBlessings, grantedBlessings, nil |
Asim Shankar | b54d764 | 2014-06-05 13:08:04 -0700 | [diff] [blame] | 704 | } |
| 705 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 706 | func (c *client) Close() { |
Mehrdad Afshari | cd9852b | 2014-09-26 11:07:35 -0700 | [diff] [blame] | 707 | defer vlog.LogCall()() |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 708 | c.vcMapMu.Lock() |
| 709 | for _, v := range c.vcMap { |
| 710 | c.streamMgr.ShutdownEndpoint(v.remoteEP) |
| 711 | } |
| 712 | c.vcMap = nil |
| 713 | c.vcMapMu.Unlock() |
| 714 | } |
| 715 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 716 | // flowClient implements the RPC client-side protocol for a single RPC, over a |
| 717 | // flow that's already connected to the server. |
| 718 | type flowClient struct { |
Todd Wang | 3425a90 | 2015-01-21 18:43:59 -0800 | [diff] [blame] | 719 | ctx *context.T // context to annotate with call details |
| 720 | dec *vom.Decoder // to decode responses and results from the server |
| 721 | enc *vom.Encoder // to encode requests and args to the server |
| 722 | server []string // Blessings bound to the server that authorize it to receive the IPC request from the client. |
| 723 | flow stream.Flow // the underlying flow |
| 724 | response ipc.Response // each decoded response message is kept here |
Asim Shankar | 1707e43 | 2014-05-29 19:42:41 -0700 | [diff] [blame] | 725 | |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 726 | discharges []security.Discharge // discharges used for this request |
| 727 | dc vc.DischargeClient // client-global discharge-client |
Andres Erbsen | b7f95f3 | 2014-07-07 12:07:56 -0700 | [diff] [blame] | 728 | |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 729 | blessings security.Blessings // the local blessings for the current RPC. |
| 730 | |
Asim Shankar | 1707e43 | 2014-05-29 19:42:41 -0700 | [diff] [blame] | 731 | sendClosedMu sync.Mutex |
| 732 | sendClosed bool // is the send side already closed? GUARDED_BY(sendClosedMu) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 733 | finished bool // has Finish() already been called? |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 734 | } |
| 735 | |
Benjamin Prosnitz | fdfbf7b | 2014-10-08 09:47:21 -0700 | [diff] [blame] | 736 | var _ ipc.Call = (*flowClient)(nil) |
| 737 | var _ ipc.Stream = (*flowClient)(nil) |
| 738 | |
Matt Rosencrantz | 4f8ac60 | 2014-12-29 14:42:48 -0800 | [diff] [blame] | 739 | func newFlowClient(ctx *context.T, server []string, flow stream.Flow, dc vc.DischargeClient) (*flowClient, error) { |
Todd Wang | 34ed4c6 | 2014-11-26 15:15:52 -0800 | [diff] [blame] | 740 | fc := &flowClient{ |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 741 | ctx: ctx, |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 742 | server: server, |
| 743 | flow: flow, |
| 744 | dc: dc, |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 745 | } |
Todd Wang | f519f8f | 2015-01-21 10:07:41 -0800 | [diff] [blame] | 746 | var err error |
Todd Wang | 3425a90 | 2015-01-21 18:43:59 -0800 | [diff] [blame] | 747 | if fc.enc, err = vom.NewBinaryEncoder(flow); err != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 748 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errVomEncoder, fc.ctx, err)) |
Todd Wang | f519f8f | 2015-01-21 10:07:41 -0800 | [diff] [blame] | 749 | return nil, fc.close(berr) |
| 750 | } |
Todd Wang | 3425a90 | 2015-01-21 18:43:59 -0800 | [diff] [blame] | 751 | if fc.dec, err = vom.NewDecoder(flow); err != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 752 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errVomDecoder, fc.ctx, err)) |
Todd Wang | f519f8f | 2015-01-21 10:07:41 -0800 | [diff] [blame] | 753 | return nil, fc.close(berr) |
Todd Wang | 34ed4c6 | 2014-11-26 15:15:52 -0800 | [diff] [blame] | 754 | } |
| 755 | return fc, nil |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 756 | } |
| 757 | |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 758 | func (fc *flowClient) close(err error) error { |
| 759 | if cerr := fc.flow.Close(); cerr != nil && err == nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 760 | return verror.New(verror.ErrInternal, fc.ctx, err) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 761 | } |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 762 | switch { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 763 | case verror.Is(err, verror.ErrBadProtocol.ID): |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 764 | switch fc.ctx.Err() { |
| 765 | case context.DeadlineExceeded: |
| 766 | // TODO(cnicolaou,m3b): reintroduce 'append' when the new verror API is done. |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 767 | //return verror.Append(verror.New(verror.ErrTimeout, fc.ctx), verr) |
| 768 | return verror.New(verror.ErrTimeout, fc.ctx, err.Error()) |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 769 | case context.Canceled: |
| 770 | // TODO(cnicolaou,m3b): reintroduce 'append' when the new verror API is done. |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 771 | //return verror.Append(verror.New(verror.ErrCanceled, fc.ctx), verr) |
| 772 | return verror.New(verror.ErrCanceled, fc.ctx, err.Error()) |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 773 | } |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 774 | case verror.Is(err, verror.ErrTimeout.ID): |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 775 | // Canceled trumps timeout. |
| 776 | if fc.ctx.Err() == context.Canceled { |
| 777 | // TODO(cnicolaou,m3b): reintroduce 'append' when the new verror API is done. |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 778 | return verror.New(verror.ErrCanceled, fc.ctx, err.Error()) |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 779 | } |
| 780 | } |
| 781 | return err |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 782 | } |
| 783 | |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 784 | func (fc *flowClient) start(suffix, method string, args []interface{}, timeout time.Duration, blessings security.Blessings) error { |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 785 | // Fetch any discharges for third-party caveats on the client's blessings |
| 786 | // if this client owns a discharge-client. |
| 787 | if self := fc.flow.LocalBlessings(); self != nil && fc.dc != nil { |
Asim Shankar | f4864f4 | 2014-11-25 18:53:05 -0800 | [diff] [blame] | 788 | fc.discharges = fc.dc.PrepareDischarges(fc.ctx, self.ThirdPartyCaveats(), mkDischargeImpetus(fc.server, method, args)) |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 789 | } |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 790 | // Encode the Blessings information for the client to authorize the flow. |
| 791 | var blessingsRequest ipc.BlessingsRequest |
| 792 | if fc.flow.LocalPrincipal() != nil { |
Jungho Ahn | 44d8daf | 2015-01-16 10:39:15 -0800 | [diff] [blame] | 793 | fc.blessings = fc.flow.LocalPrincipal().BlessingStore().ForPeer(fc.server...) |
| 794 | blessingsRequest = clientEncodeBlessings(fc.flow.VCDataCache(), fc.blessings) |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 795 | } |
Asim Shankar | ef95149 | 2015-02-11 11:41:03 -0800 | [diff] [blame] | 796 | discharges := make([]security.WireDischarge, len(fc.discharges)) |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 797 | for i, d := range fc.discharges { |
Asim Shankar | ef95149 | 2015-02-11 11:41:03 -0800 | [diff] [blame] | 798 | discharges[i] = security.MarshalDischarge(d) |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 799 | } |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 800 | req := ipc.Request{ |
Asim Shankar | 8f05c22 | 2014-10-06 22:08:19 -0700 | [diff] [blame] | 801 | Suffix: suffix, |
| 802 | Method: method, |
| 803 | NumPosArgs: uint64(len(args)), |
| 804 | Timeout: int64(timeout), |
| 805 | GrantedBlessings: security.MarshalBlessings(blessings), |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 806 | Blessings: blessingsRequest, |
Asim Shankar | ef95149 | 2015-02-11 11:41:03 -0800 | [diff] [blame] | 807 | Discharges: discharges, |
Asim Shankar | f4864f4 | 2014-11-25 18:53:05 -0800 | [diff] [blame] | 808 | TraceRequest: ivtrace.Request(fc.ctx), |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 809 | } |
| 810 | if err := fc.enc.Encode(req); err != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 811 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errRequestEncoding, fc.ctx, fmt.Sprintf("%#v", req), err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 812 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 813 | } |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 814 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 815 | for ix, arg := range args { |
| 816 | if err := fc.enc.Encode(arg); err != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 817 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errArgEncoding, fc.ctx, ix, err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 818 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 819 | } |
| 820 | } |
| 821 | return nil |
| 822 | } |
| 823 | |
| 824 | func (fc *flowClient) Send(item interface{}) error { |
Mehrdad Afshari | cd9852b | 2014-09-26 11:07:35 -0700 | [diff] [blame] | 825 | defer vlog.LogCall()() |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 826 | if fc.sendClosed { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 827 | return verror.New(verror.ErrAborted, fc.ctx) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 828 | } |
| 829 | |
| 830 | // The empty request header indicates what follows is a streaming arg. |
| 831 | if err := fc.enc.Encode(ipc.Request{}); err != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 832 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errRequestEncoding, fc.ctx, ipc.Request{}, err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 833 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 834 | } |
| 835 | if err := fc.enc.Encode(item); err != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 836 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errArgEncoding, fc.ctx, -1, err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 837 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 838 | } |
| 839 | return nil |
| 840 | } |
| 841 | |
Matt Rosencrantz | 4f8ac60 | 2014-12-29 14:42:48 -0800 | [diff] [blame] | 842 | func decodeNetError(ctx *context.T, err error) verror.IDAction { |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 843 | if neterr, ok := err.(net.Error); ok { |
| 844 | if neterr.Timeout() || neterr.Temporary() { |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 845 | // If a read is canceled in the lower levels we see |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 846 | // a timeout error - see readLocked in vc/reader.go |
| 847 | if ctx.Err() == context.Canceled { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 848 | return verror.ErrCanceled |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 849 | } |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 850 | return verror.ErrTimeout |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 851 | } |
| 852 | } |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 853 | return verror.ErrBadProtocol |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 854 | } |
| 855 | |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 856 | func (fc *flowClient) Recv(itemptr interface{}) error { |
Mehrdad Afshari | cd9852b | 2014-09-26 11:07:35 -0700 | [diff] [blame] | 857 | defer vlog.LogCall()() |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 858 | switch { |
| 859 | case fc.response.Error != nil: |
Todd Wang | 1f98c41 | 2015-02-11 14:17:35 -0800 | [diff] [blame] | 860 | // TODO(cnicolaou): this will become a verror.Standard when we convert the |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 861 | // server. |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 862 | return verror.New(verror.ErrBadProtocol, fc.ctx, fc.response.Error) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 863 | case fc.response.EndStreamResults: |
| 864 | return io.EOF |
| 865 | } |
| 866 | |
| 867 | // Decode the response header and handle errors and EOF. |
| 868 | if err := fc.dec.Decode(&fc.response); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 869 | berr := verror.New(decodeNetError(fc.ctx, err), fc.ctx, verror.New(errResponseDecoding, fc.ctx, err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 870 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 871 | } |
| 872 | if fc.response.Error != nil { |
Todd Wang | 1f98c41 | 2015-02-11 14:17:35 -0800 | [diff] [blame] | 873 | // TODO(cnicolaou): this will become a verror.Standard when we convert the |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 874 | // server. |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 875 | return verror.New(verror.ErrBadProtocol, fc.ctx, fc.response.Error) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 876 | } |
| 877 | if fc.response.EndStreamResults { |
| 878 | // Return EOF to indicate to the caller that there are no more stream |
| 879 | // results. Any error sent by the server is kept in fc.response.Error, and |
| 880 | // returned to the user in Finish. |
| 881 | return io.EOF |
| 882 | } |
| 883 | // Decode the streaming result. |
| 884 | if err := fc.dec.Decode(itemptr); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 885 | berr := verror.New(decodeNetError(fc.ctx, err), fc.ctx, verror.New(errResponseDecoding, fc.ctx, err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 886 | // TODO(cnicolaou): should we be caching this? |
| 887 | fc.response.Error = berr |
| 888 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 889 | } |
| 890 | return nil |
| 891 | } |
| 892 | |
| 893 | func (fc *flowClient) CloseSend() error { |
Mehrdad Afshari | cd9852b | 2014-09-26 11:07:35 -0700 | [diff] [blame] | 894 | defer vlog.LogCall()() |
Tilak Sharma | 0c76611 | 2014-05-20 17:47:27 -0700 | [diff] [blame] | 895 | return fc.closeSend() |
| 896 | } |
| 897 | |
Mike Burrows | dc6b360 | 2015-02-05 15:52:12 -0800 | [diff] [blame] | 898 | // closeSend ensures CloseSend always returns verror.Standard. |
| 899 | func (fc *flowClient) closeSend() error { |
Asim Shankar | 1707e43 | 2014-05-29 19:42:41 -0700 | [diff] [blame] | 900 | fc.sendClosedMu.Lock() |
| 901 | defer fc.sendClosedMu.Unlock() |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 902 | if fc.sendClosed { |
Asim Shankar | 1707e43 | 2014-05-29 19:42:41 -0700 | [diff] [blame] | 903 | return nil |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 904 | } |
| 905 | if err := fc.enc.Encode(ipc.Request{EndStreamArgs: true}); err != nil { |
Bogdan Caprita | ad5761f | 2014-09-23 10:56:23 -0700 | [diff] [blame] | 906 | // TODO(caprita): Indiscriminately closing the flow below causes |
| 907 | // a race as described in: |
| 908 | // https://docs.google.com/a/google.com/document/d/1C0kxfYhuOcStdV7tnLZELZpUhfQCZj47B0JrzbE29h8/edit |
| 909 | // |
| 910 | // There should be a finer grained way to fix this (for example, |
| 911 | // encoding errors should probably still result in closing the |
| 912 | // flow); on the flip side, there may exist other instances |
| 913 | // where we are closing the flow but should not. |
| 914 | // |
| 915 | // For now, commenting out the line below removes the flakiness |
| 916 | // from our existing unit tests, but this needs to be revisited |
| 917 | // and fixed correctly. |
| 918 | // |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 919 | // return fc.close(verror.ErrBadProtocolf("ipc: end stream args encoding failed: %v", err)) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 920 | } |
| 921 | fc.sendClosed = true |
| 922 | return nil |
| 923 | } |
| 924 | |
| 925 | func (fc *flowClient) Finish(resultptrs ...interface{}) error { |
Mehrdad Afshari | cd9852b | 2014-09-26 11:07:35 -0700 | [diff] [blame] | 926 | defer vlog.LogCall()() |
Matt Rosencrantz | 9fe6082 | 2014-09-12 10:09:53 -0700 | [diff] [blame] | 927 | err := fc.finish(resultptrs...) |
Matt Rosencrantz | 5f98d94 | 2015-01-08 13:48:30 -0800 | [diff] [blame] | 928 | vtrace.GetSpan(fc.ctx).Finish() |
Matt Rosencrantz | 9fe6082 | 2014-09-12 10:09:53 -0700 | [diff] [blame] | 929 | return err |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 930 | } |
| 931 | |
Mike Burrows | dc6b360 | 2015-02-05 15:52:12 -0800 | [diff] [blame] | 932 | // finish ensures Finish always returns a verror.Standard. |
Cosmos Nicolaou | d1ca686 | 2015-01-30 11:43:39 -0800 | [diff] [blame] | 933 | func (fc *flowClient) finish(resultptrs ...interface{}) error { |
Ken Ashcraft | 2b8309a | 2014-09-09 10:44:43 -0700 | [diff] [blame] | 934 | if fc.finished { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 935 | err := verror.New(errClientFinishAlreadyCalled, fc.ctx) |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 936 | return fc.close(verror.New(verror.ErrBadState, fc.ctx, err)) |
Ken Ashcraft | 2b8309a | 2014-09-09 10:44:43 -0700 | [diff] [blame] | 937 | } |
| 938 | fc.finished = true |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 939 | |
Todd Wang | ce3033b | 2014-05-23 17:04:44 -0700 | [diff] [blame] | 940 | // Call closeSend implicitly, if the user hasn't already called it. There are |
| 941 | // three cases: |
| 942 | // 1) Server is blocked on Recv waiting for the final request message. |
| 943 | // 2) Server has already finished processing, the final response message and |
| 944 | // out args are queued up on the client, and the flow is closed. |
| 945 | // 3) Between 1 and 2: the server isn't blocked on Recv, but the final |
| 946 | // response and args aren't queued up yet, and the flow isn't closed. |
| 947 | // |
| 948 | // We must call closeSend to handle case (1) and unblock the server; otherwise |
| 949 | // we'll deadlock with both client and server waiting for each other. We must |
| 950 | // ignore the error (if any) to handle case (2). In that case the flow is |
| 951 | // closed, meaning writes will fail and reads will succeed, and closeSend will |
| 952 | // always return an error. But this isn't a "real" error; the client should |
| 953 | // read the rest of the results and succeed. |
| 954 | _ = fc.closeSend() |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 955 | // Decode the response header, if it hasn't already been decoded by Recv. |
| 956 | if fc.response.Error == nil && !fc.response.EndStreamResults { |
| 957 | if err := fc.dec.Decode(&fc.response); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 958 | berr := verror.New(decodeNetError(fc.ctx, err), fc.ctx, verror.New(errResponseDecoding, fc.ctx, err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 959 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 960 | } |
| 961 | // The response header must indicate the streaming results have ended. |
| 962 | if fc.response.Error == nil && !fc.response.EndStreamResults { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 963 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errRemainingStreamResults, fc.ctx)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 964 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 965 | } |
| 966 | } |
Suharsh Sivakumar | 720b704 | 2014-12-22 17:33:23 -0800 | [diff] [blame] | 967 | if fc.response.AckBlessings { |
| 968 | clientAckBlessings(fc.flow.VCDataCache(), fc.blessings) |
| 969 | } |
Matt Rosencrantz | 9fe6082 | 2014-09-12 10:09:53 -0700 | [diff] [blame] | 970 | // Incorporate any VTrace info that was returned. |
Matt Rosencrantz | 5f98d94 | 2015-01-08 13:48:30 -0800 | [diff] [blame] | 971 | ivtrace.Merge(fc.ctx, fc.response.TraceResponse) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 972 | if fc.response.Error != nil { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 973 | // TODO(cnicolaou): remove verror.ErrNoAccess with verror version |
Cosmos Nicolaou | 112bf1c | 2014-11-21 15:43:11 -0800 | [diff] [blame] | 974 | // when ipc.Server is converted. |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 975 | if verror.Is(fc.response.Error, verror.ErrNoAccess.ID) && fc.dc != nil { |
Andres Erbsen | b7f95f3 | 2014-07-07 12:07:56 -0700 | [diff] [blame] | 976 | // In case the error was caused by a bad discharge, we do not want to get stuck |
| 977 | // with retrying again and again with this discharge. As there is no direct way |
| 978 | // to detect it, we conservatively flush all discharges we used from the cache. |
| 979 | // TODO(ataly,andreser): add verror.BadDischarge and handle it explicitly? |
Asim Shankar | 77befba | 2015-01-09 12:49:04 -0800 | [diff] [blame] | 980 | vlog.VI(3).Infof("Discarding %d discharges as RPC failed with %v", len(fc.discharges), fc.response.Error) |
Ankur | e49a86a | 2014-11-11 18:52:43 -0800 | [diff] [blame] | 981 | fc.dc.Invalidate(fc.discharges...) |
Andres Erbsen | b7f95f3 | 2014-07-07 12:07:56 -0700 | [diff] [blame] | 982 | } |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 983 | return fc.close(verror.Convert(verror.ErrInternal, fc.ctx, fc.response.Error)) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 984 | } |
| 985 | if got, want := fc.response.NumPosResults, uint64(len(resultptrs)); got != want { |
Jiri Simsa | 074bf36 | 2015-02-17 09:29:45 -0800 | [diff] [blame] | 986 | berr := verror.New(verror.ErrBadProtocol, fc.ctx, verror.New(errMismatchedResults, fc.ctx, got, want)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 987 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 988 | } |
| 989 | for ix, r := range resultptrs { |
| 990 | if err := fc.dec.Decode(r); err != nil { |
Todd Wang | ff73e1f | 2015-02-10 21:45:52 -0800 | [diff] [blame] | 991 | berr := verror.New(decodeNetError(fc.ctx, err), fc.ctx, verror.New(errResultDecoding, fc.ctx, ix, err)) |
Cosmos Nicolaou | 5a8a125 | 2014-12-01 14:14:25 -0800 | [diff] [blame] | 992 | return fc.close(berr) |
Jiri Simsa | 5293dcb | 2014-05-10 09:56:38 -0700 | [diff] [blame] | 993 | } |
| 994 | } |
| 995 | return fc.close(nil) |
| 996 | } |
| 997 | |
Asim Shankar | 2d731a9 | 2014-09-29 17:46:38 -0700 | [diff] [blame] | 998 | func (fc *flowClient) RemoteBlessings() ([]string, security.Blessings) { |
Asim Shankar | 8f05c22 | 2014-10-06 22:08:19 -0700 | [diff] [blame] | 999 | return fc.server, fc.flow.RemoteBlessings() |
Asim Shankar | 2d731a9 | 2014-09-29 17:46:38 -0700 | [diff] [blame] | 1000 | } |